Skip to content

Commit

Permalink
#2733 Rename GetPublicViewComponent method of IWidgetPlugin
Browse files Browse the repository at this point in the history
  • Loading branch information
RomanovM committed Dec 15, 2017
1 parent c066f3d commit 39f9458
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 12 deletions.
4 changes: 2 additions & 2 deletions src/Libraries/Nop.Services/Cms/IWidgetPlugin.cs
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ public partial interface IWidgetPlugin : IPlugin
IList<string> GetWidgetZones();

/// <summary>
/// Gets a view component for displaying plugin in public store
/// Gets a view component for displaying widget
/// </summary>
/// <param name="widgetZone">Name of the widget zone</param>
/// <param name="viewComponentName">View component name</param>
void GetPublicViewComponent(string widgetZone, out string viewComponentName);
void GetWidgetViewComponent(string widgetZone, out string viewComponentName);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -45,11 +45,11 @@ public override string GetConfigurationPageUrl()
}

/// <summary>
/// Gets a view component for displaying plugin in public store
/// Gets a view component for displaying widget
/// </summary>
/// <param name="widgetZone">Name of the widget zone</param>
/// <param name="viewComponentName">View component name</param>
public void GetPublicViewComponent(string widgetZone, out string viewComponentName)
public void GetWidgetViewComponent(string widgetZone, out string viewComponentName)
{
viewComponentName = "WidgetsGoogleAnalytics";
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<Copyright>Copyright © Nop Solutions, Ltd</Copyright>
<Company>Nop Solutions, Ltd</Company>
<Authors>Nop Solutions, Ltd</Authors>
<Version>1.37</Version>
<Version>1.39</Version>
<Description>This plugin integrates with Google Analytics. It keeps track of statistics about the visitors and ecommerce conversion on your website</Description>
<PackageLicenseUrl></PackageLicenseUrl>
<PackageProjectUrl>http://www.nopcommerce.com/</PackageProjectUrl>
Expand Down
2 changes: 1 addition & 1 deletion src/Plugins/Nop.Plugin.Widgets.GoogleAnalytics/plugin.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Group": "Widgets",
"FriendlyName": "Google Analytics or Universal Analytics",
"SystemName": "Widgets.GoogleAnalytics",
"Version": "1.38",
"Version": "1.39",
"SupportedVersions": [ "4.10" ],
"Author": "nopCommerce team, Nicolas Muniere",
"DisplayOrder": 1,
Expand Down
4 changes: 2 additions & 2 deletions src/Plugins/Nop.Plugin.Widgets.NivoSlider/NivoSliderPlugin.cs
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ public override string GetConfigurationPageUrl()
}

/// <summary>
/// Gets a view component for displaying plugin in public store
/// Gets a view component for displaying widget
/// </summary>
/// <param name="widgetZone">Name of the widget zone</param>
/// <param name="viewComponentName">View component name</param>
public void GetPublicViewComponent(string widgetZone, out string viewComponentName)
public void GetWidgetViewComponent(string widgetZone, out string viewComponentName)
{
viewComponentName = "WidgetsNivoSlider";
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<Copyright>Copyright © Nop Solutions, Ltd</Copyright>
<Company>Nop Solutions, Ltd</Company>
<Authors>Nop Solutions, Ltd</Authors>
<Version>1.23</Version>
<Version>1.24</Version>
<Description>This plugin allows you to change the contents of main page slider</Description>
<PackageLicenseUrl></PackageLicenseUrl>
<PackageProjectUrl>http://www.nopcommerce.com/</PackageProjectUrl>
Expand Down
2 changes: 1 addition & 1 deletion src/Plugins/Nop.Plugin.Widgets.NivoSlider/plugin.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"Group": "Widgets",
"FriendlyName": "Nivo Slider",
"SystemName": "Widgets.NivoSlider",
"Version": "1.23",
"Version": "1.24",
"SupportedVersions": [ "4.10" ],
"Author": "nopCommerce team",
"DisplayOrder": 1,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public IViewComponentResult Invoke(string widgetZone, object additionalData = nu
var widgets = _widgetService.LoadActiveWidgetsByWidgetZone(widgetZone);
foreach (var widget in widgets)
{
widget.GetPublicViewComponent(widgetZone, out string viewComponentName);
widget.GetWidgetViewComponent(widgetZone, out string viewComponentName);

var widgetModel = new RenderWidgetModel
{
Expand Down
2 changes: 1 addition & 1 deletion src/Presentation/Nop.Web/Factories/WidgetModelFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public virtual List<RenderWidgetModel> PrepareRenderWidgetModel(string widgetZon
var widgets = _widgetService.LoadActiveWidgetsByWidgetZone(widgetZone, _workContext.CurrentCustomer, _storeContext.CurrentStore.Id);
foreach (var widget in widgets)
{
widget.GetPublicViewComponent(widgetZone, out string viewComponentName);
widget.GetWidgetViewComponent(widgetZone, out string viewComponentName);
var widgetModel = new RenderWidgetModel
{
Expand Down

0 comments on commit 39f9458

Please sign in to comment.