Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit shopping cart item functionality does not pre-set correct picture #1133

Closed
AndreiMaz opened this issue Jan 29, 2016 · 0 comments
Closed
Assignees
Milestone

Comments

@AndreiMaz
Copy link
Member

AndreiMaz commented Jan 29, 2016

If you click on the "edit" buttton, then all product attributes are pre-selected (as per shopping cart item). We should also pre-set the main picture if some of the selected attributes has custom picture.

The same happens when some attribute is pre-selected and this product details page is open (even not "edit" mode)

The issue is that there could multiple (distinct) attributes that change pictures. For example, attribute 1 with some value has one picture. But attribute 2 with some value has other one. Imagine that both of them are pre-selected. Which picture should we display? Maybe, the one of an attribute with higher display order?

Or we can load pictures using AJAX (the same as it's done for dynamic price update). Anyway we're going to introduce pictures per attributes soon - #290 (most probably)

@AndreiMaz AndreiMaz added this to the Version 3.80 milestone Jan 29, 2016
@AndreiMaz AndreiMaz self-assigned this Jun 8, 2016
AndreiMaz added a commit that referenced this issue Jun 29, 2016
…icture (associated to attribute values). The same issue was with pre-selected attribute values (with associated pictures).

P.S. Now we load associated pictures using AJAX (the same way as it's done for dynamic pricing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant