Html class name missing on "customer product reviews" page #2473
Comments
AndreiMaz
added a commit
that referenced
this issue
Aug 4, 2017
f1ana
added a commit
to f1ana/nopCommerce
that referenced
this issue
Aug 12, 2017
* Added _ViewImports.cshtml to the default theme
* Remove obsolete code related with machineKey
* Use shared model for OrderSummary component. We should avoid full cshtml paths (otherwise, it couldn't be overridden in themes)
* We should override "GetConfigurationPageUrl" method in Australia Post plugin
* Revert back use of the "HTTP_CLUSTER_HTTPS" to detect https
* Made HostingConfig properties not nullable. Anyway if not specified, it'll be "false".
* Fxied an issue with not localizable URLs. They should be redirected to localizable paths such as /en
* Fixed issue with localizable URLs. Redirection on the home page didn't work fine in some cases
* Fixed localizable URLs in virtual directory (virtual path was ignored)
* Removed extra dot in source code comment
* Remove unsed variable
* Ensure external authentication works in virtual directories
* More changes with "#if NET451"
* More changes with "#if NET451"
* Fixed admin AutoMapper configuration errors
* Updated third-party libraries to the latest version
* Source code formatting. Removed empty line
* Change priority of RouteProviders of PayPal plugins
* Renamed PayPal plugin namespace
* Add redirect after successful external authentication
* Invoke View Components synchronously
* Replace obsolete custom validation for FluentValidation validators
* Remove unused variable
* Fix build warning related to target platform of the Nop.Web
* New way to get a plugin in the _ConfigurePlugin layout
* More changes with "#if NET451"
* Reverted back changes with target platform
* Removed unused locales
* More changes with "#if NET451"
* Further changes in tag helpers
* Delete "ExternalAuthenticationSettings.AutoRegisterEnabled" setting
* Added a comment to the checkbox duplicating workaround
* Further changes in NopSelectTagHelper
* Use tag helpers on the activity log pages
* Use tag helpers on the address attribute pages
* Fixed cache key typo in nivo slider plugin.
* Source code formatting
* Use "asp-all-route-data" to automatically generate "action" form attribute (including query string)* for popup windows
* Updated NuGet packages to the latest version
* Use tag helpers on the widgets page
* Use tag helpers on vendor pages
* Further changes on tag helpers for vendor pages
* returnurl wasn't used on the login page
* Tag helpers for topci pages
* Minor formatting changes on other views
* Further tag helper changes. Templates
* Tag helpers on tax category and tax provider list pages
* Tag helpers for store pages
* Tag helpers for specification attribute pages
* Fixed "nop-editor" implementation. It didn't work for localizable properties
* Replaced "Html.FieldIdFor" with the built-in "Html.IdFor". Replaced "Html.FieldNameFor" with the built-in "Html.NameFor".
* Tag helpers on shopping cart and wishlist pages
* Tag helpers for shipping method pages
* Tag helpers for the shipping provider lsit page
* Tag helpers for shipping pickup point providers
* Tag helpers for shipping restictions
* Further changes on shipping methods
* Tag helpers for warehouses
* Tag helpers for delivery dates
* Further changes on tag helpers for delivery dates
* Tag helpers for shared views
* Further changes on tag helpers
* Tag helpers for components. Minor formatting changes
* NopLabelTagHelper didn't properly encode hints
* "nop-override-store-checkbox" tag helper
* Postfix support for "nop-editor"
* Render tabs' script automatically in the tag helper
* Further changes on nop-editor
* Use RenderHtmlContent method in NopEditorTagHelper
* Render selected-tab-name input in tag helper
* Removed the code which was moved to the NopTabsTagHelper from the category and address attribute page
* Tag helpers for blog pages
* Tag helpers for setting pages
* Use RenderHtmlContent method in other tag editors
* Applied latest <nop-tab> changes to other views. Now there's no need to manually specify "selected-tab-name" name="selected-tab-name" and "bindBootstrapTabSelectEvent" event
* Tag helpers for campaigns
* Tag helpers for checkout attributes
* Tag helpers for security pages
* Tag helpers for the schedule task list page
* Tag helpers for common pages
* Tag helpers for return requests
* Tag helpers for recurring payments
* Tag helpers for countries
* Tag helpers for queued email pages
* Further changes in NopSelectTagHelper
* Tag helpers for currency pages
* Don't use closing tag for nop-select anymore
* Added support of all attributes to the NopSelectTagHelper
* Use tag helpers in StoreScopeConfiguration component
* Tag helpers for product reviews
* Tag helpers for product attributes
* Tag helpers for customer pages
* Tag helpers for customer attributes
* Tag helpers for customer roles
* Tag helpers for discounts
* Further changes in tag helpers for customers
* Tag helpers for email accounts
* Tag helpers for product pages
* Added comments to source code
* Typo fixed
* Source code formatting
* Fixed compilation warnings
* Updated "RedLock.net.StrongName" third-party library to the latest version
* Tag helpers for poll pages
* Tag helpers for plugins
* Tag helpers for payment methods
* Tag helpers for order and shipment pages
* Tag helpers for the online customer page
* Tag helpers for the newsletter subscribers page
* Add "form-control" class in the NopEditorTagHelper
* Tag helpers for news pages
* Tag helpers for external authentication
* Tag helpers for message templates
* Tag helpers for the measures page
* Tag helpers for forum
* Tag helpers for manufacturers
* Tag helpers for log pages
* Tag helpers for language pages
* Tag helpers for gift card
* Further changes in tag helpers on the language create/update page
* Further changes in tag helpers on the language create/update page
* Further changes on NopDropDownListFor
* Further changes on tag helpers
* Replaced all HiddenFor and ValidationSummary with tag helpers
* Replaced all [UIHint("MultiSelect")] with tag helpers
* Use asp-action in 'a' tag instead of href attribute
* Use <nop-required /> instead of @Html.RequiredHint()
* Removed an obsolete method
* Removed more obsolete methods
* Removed unused "usage" directives
* Fixed password recovery email
* Minor formatting changes
* Updated _ViewImport.cshtml in plugins
* Tag helpers for discount requirement plugins
* Tag helpers for Facebook plugin
* MInor formatting changes
* Removed obsolete code
* Taxonomy.txt file should be embedded in Google Shopping plugin (caused by a recent change in a plugin project files)
* Tag helpers for Google Shopping plugin
* Further changes on Facebook plugin
* Tag helpers for payment plugins
* Tag helpers for pickup in store plugin
* Canada post issue fixed when saving the configuration page with empty values
* Tag helpers for shipping plugins
* Tag helpers for tax provider
* Tag helpers for widget plugins
* Removed obsolete HTML extension methods such as NopEditorFor, NopDownDownlistFor, etc. Now we use tag helpers
* Replaced all Html.BeginForm with tag helpers
* Replaced Html.Hidden with tag helpers
* PayPal Standard namespace issue fixed
* Updated "Autofac.Extensions.DependencyInjection" to the latest version
* Change scheduled tasks to use web requests
* Add option to configure the data protection system to persist keys in the Redis database
* Fixed formatting of code
* Fixed possibility error in TaskThread.Run method
* Removed extra class from tabs
* Further changes in tabs
* Use tag helper to generate antiforgery token instead of @Html.AntiForgeryToken()
* Don't generate antiforgery token in form because it's generated automatically
* Use tag helper to generate antiforgery token instead of @Html.AntiForgeryToken() in Nop.Web
* Use tag helper instead of DeleteConfirmation extension ,ethod
* Use tag helper instead of DeleteConfirmation extension method on the specification attributes page
* Use tag helper instead of ActionConfirmation extension method
* Further changes in tag helpers for the Google Shopping plugin
* Removed unused temporary file
* Removed unused extension methods
* Use NopDatePickerTagHelper instead of Html.DatePickerDropDowns extension method
* Fixed date of birth validation bug
* Refactoring of forms. Don't use <form asp-all-route-data="@null">
* Consistent writing of asp-items. Do not use @model. Write just Model without @
* Don't show the default input spinners with the input type 'number'
* Tabs tag helpers moved from the separate folder and added into one file
* nopSolutions#2403 Updatde all links to www.nopCommerce.com with HTTPS
* nopSolutions#2357 Homepage topic. Updated a link to the documentation portal
* nopSolutions#2279 Source code typo fixed
* nopSolutions#2298 Localization errors fixed
* Use 'a' tag instead of Html.ActionLink
* Minor source code comment changes
* Changed scheduler task url
* Fixed errors on validator tests
* Use NopBBCodeEditorTagHelper instead of Html.BBCodeEditor
* Further changes in NopBBCodeEditorTagHelper
* Use NopGenerateCaptchaTagHelper instead of Html.GenerateCaptcha method
* Renamed nop-generate-captcha to nop-captcha
* Issue 2216 Disallow the use of the seo name is the same as the language code
* Add request query string to url on the internal redirection
* Minor formatting changes
* Changes in .gtignore (ensure that directories are created in repository)
* nopSolutions#2254 Updated description of "Category thumbnail image size" and "Manufacturer thumbnail image size" (media settings)
* nopSolutions#2237 Source code typos fixed (a lot)
* Updated third-party libraries to the latest version (FluentValidation, Autofac, Azure storage, Redis)
* Moves password salt key size to constant
* nopSolutions#2237 Source code typos fixed
* Removed outdated source code comment
* nopSolutions#295 Use more secure password hashing algorithm
* nopSolutions#2461 Added "Store IP addresses" customer setting. When enabled, IP addresses of customers will be stored. It's prohibited to store IP addresses in some countries (private customer data). For example, In Germany now.
* nopSolutions#2456 Don't use ViewBag to store btnId and formId value in popup windows. Get these values from query string
* nopSolutions#295 Further changes on new hashing algorith
* Simplified on run scheduler task on web-farm
* Fixed a recent styling issue on the insrallation page (missing CSS class)
* nopSolutions#2308 Checkout attributes: 'RGB color' input cannot be set after changing attribute type to 'Color squares' (from any other type)
Refactoring of product attributes the same way
* nopSolutions#2336 Topics protected with passwords should use unique ID for a hidden input
* Some of refactoring of PayPal Standard payment plugin
* Removed unused "usage" directives
* Minor refactoring. Passing valid classes in "ResetCheckoutData" method when saving attributes
* nopSolutions#2467 Selected checkout attributes were lost after login. Fixed
* Fixed validation. Server-based validation (Model.IsValid) is suppressed in ASP.NET Core if you have IFormCollection as input paramater in your controller action methods. You should add them to appropriate models as a property if you want to use them. The only exception is action methods without models (and hence without validation). More info: https://github.com/aspnet/Mvc/blob/373361675c74af3376bcfa59cb881519e79081c5/src/Microsoft.AspNet.Mvc.Core/ModelBinding/FormCollectionModelBinder.cs#L54
* Validation of child properties. Now we have to manually validate them
* Cardholder name wasn't preset in "Manual" payment method after postback with wrong validation
* Refactoring of CheckoutController. Adjusting validation logic for new ASP.NET implementation
* Wrong hint was used
* Fixed an issue with "Disable billing address" issue (caused by a recent changes)
* Source code typo fixed
* nopSolutions#2476 Discounts weren't displayed for recurring orders
* Fixed validation issues for "State / province" when errors weren't visible. We should not use RuleFor(x => x) in FeluntValidation.
* Removed obsolete code
* Added clearing plugins folders
* nopSolutions#2473 Added a missing HTML class name to the "customer product reviews" page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
he html tag in "customer product reviews" page in "my account" section is missing its common class name ("html-account-page"). It seems the required code (Html.AppendPageCssClassParts("html-account-page");) is not implemented.
Perhaps you can fix this in the next nopCommerce version, all other account pages are having this class name.
Source: https://www.nopcommerce.com/boards/t/48162/html-class-name-missing-on-customer-product-reviews-page.aspx
The text was updated successfully, but these errors were encountered: