Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload plugin. Ensure all files are extracted #2687

Closed
AndreiMaz opened this issue Oct 25, 2017 · 0 comments
Closed

Upload plugin. Ensure all files are extracted #2687

AndreiMaz opened this issue Oct 25, 2017 · 0 comments
Assignees
Milestone

Comments

@AndreiMaz
Copy link
Member

I tried to upload several plugins from a single zip and some of the files from the Zip were not copied.
By quickly looking at the code I noticed this in the UploadMultiplePlugins method:

if (!Directory.Exists(directoryPath))
Directory.CreateDirectory(directoryPath);
else
entry.ExtractToFile(entryPath);

the code above skips the first file in a folder.
It should be without the else clause in order to work properly.

if (!Directory.Exists(directoryPath))
{
Directory.CreateDirectory(directoryPath);
}

entry.ExtractToFile(entryPath);

Unfortunately we don't have much time to test this more as we are busy with the upgrade of the themes and plugins but I would suggest you to test this functionality a bit more.

Source: https://www.nopcommerce.com/boards/t/48672/nopcommerce-40-bug-fixes-and-improvements.aspx?p=5#195182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants