You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I tried to upload several plugins from a single zip and some of the files from the Zip were not copied.
By quickly looking at the code I noticed this in the UploadMultiplePlugins method:
if (!Directory.Exists(directoryPath))
Directory.CreateDirectory(directoryPath);
else
entry.ExtractToFile(entryPath);
the code above skips the first file in a folder.
It should be without the else clause in order to work properly.
if (!Directory.Exists(directoryPath))
{
Directory.CreateDirectory(directoryPath);
}
entry.ExtractToFile(entryPath);
Unfortunately we don't have much time to test this more as we are busy with the upgrade of the themes and plugins but I would suggest you to test this functionality a bit more.
I tried to upload several plugins from a single zip and some of the files from the Zip were not copied.
By quickly looking at the code I noticed this in the UploadMultiplePlugins method:
if (!Directory.Exists(directoryPath))
Directory.CreateDirectory(directoryPath);
else
entry.ExtractToFile(entryPath);
the code above skips the first file in a folder.
It should be without the else clause in order to work properly.
if (!Directory.Exists(directoryPath))
{
Directory.CreateDirectory(directoryPath);
}
entry.ExtractToFile(entryPath);
Unfortunately we don't have much time to test this more as we are busy with the upgrade of the themes and plugins but I would suggest you to test this functionality a bit more.
Source: https://www.nopcommerce.com/boards/t/48672/nopcommerce-40-bug-fixes-and-improvements.aspx?p=5#195182
The text was updated successfully, but these errors were encountered: