Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display a warning if multiple plugins try to override the same interface, etc #2805

Closed
AndreiMaz opened this issue Dec 29, 2017 · 4 comments
Closed

Display a warning if multiple plugins try to override the same interface, etc #2805

AndreiMaz opened this issue Dec 29, 2017 · 4 comments
Assignees
@skoshelev
Labels
refactoring / source code
Milestone
Version 4.40

Comments

@AndreiMaz
Copy link
Member

This way there won't be any conflicts (issues). For example, if two plugins override the same service
@AndreiMaz AndreiMaz added this to the Version 4.10 milestone Dec 29, 2017
@RomanovM RomanovM assigned skoshelev and unassigned RomanovM Feb 16, 2018
@AndreiMaz AndreiMaz removed this from the Version 4.10 milestone Jun 22, 2018
@mewajda
Copy link

mewajda commented Jul 20, 2018

Please try to make this a priority feature. A colleague and I just spent hours trying to figure out why a plugins' code wasn't firing. It turned out that 3 other plugins were overriding the same service as the plugin in question, but those plugins were registered later. This would be very helpful to bring to the attention of store owner/devs if it happens.

@AndreiMaz AndreiMaz added this to the Version 4.20 milestone Aug 2, 2018
@AndreiMaz AndreiMaz removed this from the Version 4.20 milestone Apr 2, 2019
@AndreiMaz AndreiMaz added this to the Version 4.40 milestone Jun 15, 2020
skoshelev added a commit that referenced this issue Sep 14, 2020
@skoshelev
#2805 Display a warning if multiple plugins try to override the same…
c3ac7f6 
… service
@skoshelev
Copy link
Contributor

Closed #2805

@RomanovM RomanovM reopened this Feb 9, 2021
@RomanovM
Copy link
Contributor

RomanovM commented Feb 9, 2021

Reopened since moved to net core service provider (details here).

skoshelev added a commit that referenced this issue Feb 16, 2021
@skoshelev
#2805 Rewritten "Display a warning if multiple plugins try to overrid…
60e2501 
…e the same service" mechanism to use with new IoC
@skoshelev
Copy link
Contributor

Closed #2805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skoshelev skoshelev

Labels
refactoring / source code
Projects
None yet
Milestone
Version 4.40
Development

No branches or pull requests
4 participants
@AndreiMaz @mewajda @RomanovM @skoshelev