Mark attribute combinations as unavailable #2909

vucetica · 2018-03-09T18:28:45Z

nopCommerce version: 4.0

Expected behavior: When the user selects an attribute value, attribute values for available attribute combinations should be differentiated from the ones that are not available. Screenshot from amazon is attached (page https://smile.amazon.com/Blue-Cache-Desktop-Drive-WD10EZEX/dp/B013HNYVCE):

Actual behavior: User has to click on many combinations to figure out which one is in stock.

Steps to reproduce the problem: Open a product page for a product whose inventory is managed through attribute combinations, having some of the combinations unavailable or out of stock.

Suggested solution

Server side

shoppingcart/productdetails_attributechange action should receive one more parameter: selected_product_attribute_id, which is the id of the attribute that user clicked on.
if shoppingcart/productdetails_attributechange action receives selected_product_attribute_id it should return one more property:
...
accepted_attribute_values: [
{
attribute_id: 1981,
accepted_value_ids: [123, 123],
unaccepted_value_ids: [222]
},
{
attribute_id: 1981,
accepted_value_ids: [127, 128],
unaccepted_value_ids: []
}
]
...

This result will be built using these rules:
2.1. Find all product attribute combinations that are valid for the selected value of selected_product_attribute_id.
2.2. For each attribute in the product, buld a return object with these properties:
attribute_id - id of that attribute
accepted_value_ids - go through all attribute values and pick those that appear in acceptable combinations
unaccepted_value_ids - the opposite from accepted_value_ids

Client side

When shoppingcart/productdetails_attributechange is completed, for all attribute values remove css classes "accepted" and "unaccepted". For all attribute values in the accepted_value_ids list, add "accepted" css class, for the ones in unaccepted_value_ids add "unaccepted" css class.

vucetica · 2018-03-12T13:40:14Z

@AndreiMaz, I would like to implement this solution as proposed. Is that ok?

Araujovski · 2019-12-20T09:19:51Z

nopCommerce version: 4.0

Expected behavior: When the user selects an attribute value, attribute values for available attribute combinations should be differentiated from the ones that are not available. Screenshot from amazon is attached (page https://smile.amazon.com/Blue-Cache-Desktop-Drive-WD10EZEX/dp/B013HNYVCE):

Actual behavior: User has to click on many combinations to figure out which one is in stock.

Steps to reproduce the problem: Open a product page for a product whose inventory is managed through attribute combinations, having some of the combinations unavailable or out of stock.

Suggested solution

Server side

shoppingcart/productdetails_attributechange action should receive one more parameter: selected_product_attribute_id, which is the id of the attribute that user clicked on.

if shoppingcart/productdetails_attributechange action receives selected_product_attribute_id it should return one more property:
...
accepted_attribute_values: [
{
attribute_id: 1981,
accepted_value_ids: [123, 123],
unaccepted_value_ids: [222]
},
{
attribute_id: 1981,
accepted_value_ids: [127, 128],
unaccepted_value_ids: []
}
]
...

This result will be built using these rules:
2.1. Find all product attribute combinations that are valid for the selected value of selected_product_attribute_id.
2.2. For each attribute in the product, buld a return object with these properties:
attribute_id - id of that attribute
accepted_value_ids - go through all attribute values and pick those that appear in acceptable combinations
unaccepted_value_ids - the opposite from accepted_value_ids

Client side

When shoppingcart/productdetails_attributechange is completed, for all attribute values remove css classes "accepted" and "unaccepted". For all attribute values in the accepted_value_ids list, add "accepted" css class, for the ones in unaccepted_value_ids add "unaccepted" css class.

Hi Vucetica,

I don't understand.
Can you help me? Please.

Best Regards,
Araujovski.

vucetica · 2019-12-20T14:25:10Z

Hi @Araujovski.

Can you clarify? Which part you don't understand?

Araujovski · 2019-12-20T14:33:04Z

Hi, I have two lists: ->valid attributes ; ->invalid attributes. This is developted in "ShoppingCartController". It's work... but don't work in client side... I think it is "_ProductAtributes.cshtml". I'm so sad. Can you help me? Best Regards, Araujovski.

…

________________________________ De: Aleksandar Vucetic <notifications@github.com> Enviado: 20 de dezembro de 2019 14:25 Para: nopSolutions/nopCommerce <nopCommerce@noreply.github.com> Cc: Araujovski <luyx.bcl@hotmail.com>; Mention <mention@noreply.github.com> Assunto: Re: [nopSolutions/nopCommerce] Mark attribute combinations as unavailable (#2909) Hi @Araujovski<https://github.com/Araujovski>. Can you clarify? Which part you don't understand? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#2909?email_source=notifications&email_token=AIKGM3SAH25LFVML5PI7RXDQZTIUPA5CNFSM4EUSWWP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHNBXRA#issuecomment-567942084>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIKGM3T67OQZXMX6XIRQCCDQZTIUPANCNFSM4EUSWWPQ>.

vucetica · 2019-12-20T14:56:04Z

@Araujovski , I didn't implement this in the end (and not working on nopcommerce stuff these days). Guys from nopcommerce marked it as onhold/won't do. I see that it is active now, and I'm not sure if someone from the nopcommerce team is working on it.

Araujovski · 2019-12-20T15:00:08Z

In atually no one is working on it. Do you know what you can call client side controller values? Best Regards, Araujovski.

…

________________________________ De: Aleksandar Vucetic <notifications@github.com> Enviado: 20 de dezembro de 2019 14:56 Para: nopSolutions/nopCommerce <nopCommerce@noreply.github.com> Cc: Araujovski <luyx.bcl@hotmail.com>; Mention <mention@noreply.github.com> Assunto: Re: [nopSolutions/nopCommerce] Mark attribute combinations as unavailable (#2909) @Araujovski<https://github.com/Araujovski> , I didn't implement this in the end (and not working on nopcommerce stuff these days). Guys from nopcommerce marked it as onhold/won't do. I see that it is active now, and I'm not sure if someone from the nopcommerce team is working on it. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#2909?email_source=notifications&email_token=AIKGM3T6EOI7GPYPW2QNBRLQZTMILA5CNFSM4EUSWWP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHNEJFI#issuecomment-567952533>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIKGM3SHSBLT624AYTG2N6TQZTMILANCNFSM4EUSWWPQ>.

vucetica · 2019-12-20T15:19:40Z

Sorry, not on the project anymore.

Araujovski · 2019-12-20T15:35:08Z

but know what you can call client side controller values? Please...

…

________________________________ De: Aleksandar Vucetic <notifications@github.com> Enviado: 20 de dezembro de 2019 15:19 Para: nopSolutions/nopCommerce <nopCommerce@noreply.github.com> Cc: Araujovski <luyx.bcl@hotmail.com>; Mention <mention@noreply.github.com> Assunto: Re: [nopSolutions/nopCommerce] Mark attribute combinations as unavailable (#2909) Sorry, not on the project anymore. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#2909?email_source=notifications&email_token=AIKGM3QEWUUHN4BYGNR7GILQZTPA3A5CNFSM4EUSWWP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHNGHIQ#issuecomment-567960482>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIKGM3S3KNF6YU3UMC7AF7DQZTPA3ANCNFSM4EUSWWPQ>.

vucetica · 2019-12-20T16:45:42Z

@Araujovski , I really don't understand the question. What do you mean by "what you can call client side controller values"? Can you give me an example?

Araujovski · 2019-12-20T17:03:17Z

I have two lists: -> disabledAttributeValues; -> enabledAttributeValues; In function "ProductDetails_AttributeChange", this function belongs "ShoppingCartController.cs". How do I analyze these two lists in client side? Best Regards, Araujovski.

…

________________________________ De: Aleksandar Vucetic <notifications@github.com> Enviado: 20 de dezembro de 2019 16:45 Para: nopSolutions/nopCommerce <nopCommerce@noreply.github.com> Cc: Araujovski <luyx.bcl@hotmail.com>; Mention <mention@noreply.github.com> Assunto: Re: [nopSolutions/nopCommerce] Mark attribute combinations as unavailable (#2909) @Araujovski<https://github.com/Araujovski> , I really don't understand the question. What do you mean by "what you can call client side controller values"? Can you give me an example? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#2909?email_source=notifications&email_token=AIKGM3RA4XXUIKDJZZMVO5DQZTZDRA5CNFSM4EUSWWP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHNNQQA#issuecomment-567990336>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIKGM3T74UBIQ4PLXPXCJW3QZTZDRANCNFSM4EUSWWPQ>.

vucetica · 2019-12-20T17:13:41Z

I'm sorry, I can't help you with that.

Araujovski · 2019-12-20T17:31:51Z

Why?

…

________________________________ De: Aleksandar Vucetic <notifications@github.com> Enviado: 20 de dezembro de 2019 17:13 Para: nopSolutions/nopCommerce <nopCommerce@noreply.github.com> Cc: Araujovski <luyx.bcl@hotmail.com>; Mention <mention@noreply.github.com> Assunto: Re: [nopSolutions/nopCommerce] Mark attribute combinations as unavailable (#2909) I'm sorry, I can't help you with that. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#2909?email_source=notifications&email_token=AIKGM3QJMXWPGMFD3TWUCXLQZT4MPA5CNFSM4EUSWWP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHNRGCA#issuecomment-568005384>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AIKGM3TKLYKYLULZH4GGUMTQZT4MPANCNFSM4EUSWWPQ>.

holydk · 2021-02-21T15:55:36Z

Closed #2909

AndreiMaz added the on hold / maybe wont label Mar 11, 2018

AndreiMaz added functionality / feature and removed on hold / maybe wont labels Jul 12, 2018

mariannk mentioned this issue Jun 8, 2020

Add an option to display only attribute combinations that exist and have stock greater than zero #16

Closed

RomanovM assigned holydk Oct 13, 2020

holydk mentioned this issue Nov 2, 2020

Making the combination attribute to be disabled when stock is 0 #5071

Closed

holydk added this to the Version 4.40 milestone Nov 2, 2020

holydk added a commit that referenced this issue Feb 21, 2021

#16 #2909 Support for displaying only available combinations

5c01b47

holydk added a commit that referenced this issue Feb 21, 2021

#16 #2909 Add enum locales

dc9d085

holydk closed this as completed Feb 21, 2021

holydk mentioned this issue Feb 21, 2021

Second product attribute IsRequired not working #4022

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mark attribute combinations as unavailable #2909

Mark attribute combinations as unavailable #2909

vucetica commented Mar 9, 2018 •

edited

vucetica commented Mar 12, 2018

Araujovski commented Dec 20, 2019

Suggested solution

Server side

Client side

vucetica commented Dec 20, 2019

Araujovski commented Dec 20, 2019 via email

vucetica commented Dec 20, 2019

Araujovski commented Dec 20, 2019 via email

vucetica commented Dec 20, 2019

Araujovski commented Dec 20, 2019 via email

vucetica commented Dec 20, 2019

Araujovski commented Dec 20, 2019 via email

vucetica commented Dec 20, 2019

Araujovski commented Dec 20, 2019 via email

holydk commented Feb 21, 2021

Mark attribute combinations as unavailable #2909

Mark attribute combinations as unavailable #2909

Comments

vucetica commented Mar 9, 2018 • edited

Suggested solution

Server side

Client side

vucetica commented Mar 12, 2018

Araujovski commented Dec 20, 2019

Suggested solution

Server side

Client side

vucetica commented Dec 20, 2019

Araujovski commented Dec 20, 2019 via email

vucetica commented Dec 20, 2019

Araujovski commented Dec 20, 2019 via email

vucetica commented Dec 20, 2019

Araujovski commented Dec 20, 2019 via email

vucetica commented Dec 20, 2019

Araujovski commented Dec 20, 2019 via email

vucetica commented Dec 20, 2019

Araujovski commented Dec 20, 2019 via email

holydk commented Feb 21, 2021

vucetica commented Mar 9, 2018 •

edited