Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tier Price deleted after Editing #4298

Closed
RomanovM opened this issue Feb 18, 2020 · 3 comments
Closed

Tier Price deleted after Editing #4298

RomanovM opened this issue Feb 18, 2020 · 3 comments
Assignees
Labels
Milestone

Comments

@RomanovM
Copy link
Contributor

nopCommerce version: 4.20

I found the Tier Price gets deleted after editing it. Creation and deletion of the Tier Price work fine. Changing 'Customer Role' along with 'Price' prevents the issue from time to time but not guaranteed.

Source: https://www.nopcommerce.com/boards/topic/78132/nopcommerce-42-tier-price-gets-deletec-after-editing

@RomanovM RomanovM added the bug label Feb 18, 2020
@RomanovM RomanovM added this to the Version 4.30 milestone Feb 18, 2020
@holydk
Copy link
Contributor

holydk commented Mar 13, 2020

It's already fixed in 4.30 version. Closed #4298

@holydk holydk closed this as completed Mar 13, 2020
@Mehnock
Copy link

Mehnock commented Jun 8, 2020

Can this be fixed for 4.2? We are not planning on switching to 4.3 yet and this bug is a show stopper for us.

@Mehnock
Copy link

Mehnock commented Jun 9, 2020

I created a workaround that may help determine the source of the problem. It's described here:
https://www.nopcommerce.com/en/boards/topic/78132/nopcommerce-42-tier-price-gets-deletec-after-editing/page/2#265956

In case you can take a look.

What I found is that if we send the tierPrice entity to the context with a null CustomerRole [virtual] property, the context deletes the tierPrice instead of updating it, even though the CustomerRoleId property is set. I think this is a bug in the EFCore but my workaround works but ensuring we don't send a null CustomerRole back to the context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants