Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video list issue with RoxyFileman in rich editor #4597

Closed
rajupaladiya opened this issue Apr 19, 2020 · 6 comments
Closed

Video list issue with RoxyFileman in rich editor #4597

rajupaladiya opened this issue Apr 19, 2020 · 6 comments

Comments

@rajupaladiya
Copy link

rajupaladiya commented Apr 19, 2020

nopCommerce version: 4.30 Beta

Steps to reproduce the problem:
Go to Admin > Category Edit page > Full description Rich editor (Any rich editor)

Go to insert > Video then upload any video.
Here are two problems

  1. If video is large (more than 20 or 25 MB) then it not uploading, status shows success but in file folder video not save
  2. Small size uploaded and saved in upload folder successfully but it not showing in RoxyFileMane browse window

Here is video
https://www.loom.com/share/2bc0087350574b32afb2a8401dd2a181

@AndreiMaz
Copy link
Member

@rajupaladiya

  1. Maximum file size is the default limitation of asp.net core. You can edit this setting
  2. It's an image editor, not video. So it's OK and is limited by the "type" parameter at https://github.com/nopSolutions/nopCommerce/blob/develop/src/Presentation/Nop.Web/Areas/Admin/Controllers/RoxyFilemanController.cs#L82. But we'll think about limiting a list of type that could be uploaded - https://github.com/nopSolutions/nopCommerce/blob/develop/src/Presentation/Nop.Web/wwwroot/lib/Roxy_Fileman/conf.json#L12

@PRudykIteo
Copy link
Contributor

@AndreiMaz I came across same issue few days ago.
I can understand that You may not want videos in f.e. product description.
However, IMHO, behavior of RF is confusing - video file uploads correctly and RF shows brief success message but file disappears in a blink of an eye from Roxy window.

I was able to fix this and add a video to product description (mainly by tweaking "type" You've mentioned). I can send You a PR if You want.

@rajupaladiya
Copy link
Author

@PRudykIteo - if you do that then it would be good. I don't think @AndreiMaz sshow complete video and closed issue without check.

@AndreiMaz - I was telling about video and I uploaded video from video menu, not from pictures.

9
10

@PRudykIteo
Copy link
Contributor

@AndreiMaz do You want me to share a possible solution in pull request?

@AndreiMaz
Copy link
Member

@PRudykIteo Sure, you're more than welcome

@holydk
Copy link
Contributor

holydk commented Apr 29, 2020

Closed #4597

@holydk holydk closed this as completed Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants