Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discount Requirement - Group name should not be empty - It fills blank value to DD due to empty #4614

Closed
sk5202 opened this issue Apr 25, 2020 · 1 comment
Closed

Discount Requirement - Group name should not be empty - It fills blank value to DD due to empty #4614

sk5202 opened this issue Apr 25, 2020 · 1 comment
Assignees
@exileDev
Labels
bug
Milestone
Version 4.30

Comments

@sk5202
Copy link

sk5202 commented Apr 25, 2020 •
edited

nopCommerce version: 4.30 beta

Steps to reproduce the problem:

  1. Go /Admin/Discount/Edit/2

  2. Discount requirement type - Add requirement group

  3. Group name leave as black and click save 4 to 5 times

  4. And see the Add to group dropdown is empty due to lots of empty record.

So It should not be empty validation should be there Group name should not be empty.

https://www.loom.com/share/63fdb8f5042f471a8a6c34cc0e493f6a
pureshad pushed a commit to pureshad/nopCommerce that referenced this issue Apr 28, 2020
This is a possible solution for issue nopSolutions#4614.
6708139 
This change validates the group name an throws an argument exception if the name is empty
@AndreiMaz AndreiMaz added this to the Version 4.30 milestone Apr 28, 2020
exileDev added a commit that referenced this issue Apr 29, 2020
@exileDev
#4614 Fixed creating discount requirements with an empty name
0180211
@exileDev
Copy link
Contributor

Closed #4614

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@exileDev exileDev

Labels
bug
Projects
None yet
Milestone
Version 4.30
Development

No branches or pull requests
3 participants
@AndreiMaz @exileDev @sk5202