Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display more user-friendly error when uploading non-picture file as a picture #4919

Closed
AndreiMaz opened this issue Jul 8, 2020 · 5 comments

Comments

@AndreiMaz
Copy link
Member

Steps to reproduce the problem:

  1. Upload any non-picture file (e.g. XML or .cs) as a picture. For example, on a product details page
  2. It gives a correct message that uploading failed. But also, 'Object reference not set to an instance of an object.' throwing error on picture controller side.

Let's handle the exception so it's not thrown. There should be just an error text without an unhandled exception
download

Source: https://www.nopcommerce.com/en/boards/topic/84221/picture-controller-in-get-error-object-reference-not-set-to-an-instance-of-an-object

@badijm
Copy link
Contributor

badijm commented Jul 9, 2020

Hi, I can grab this item if available.

@badijm
Copy link
Contributor

badijm commented Aug 9, 2020

@AndreiMaz Hi, I've send the PR. Lemme know if it works for ya.

@AndreiMaz
Copy link
Member Author

@badijm Please create the PR at https://github.com/nopSolutions/nopCommerce/pulls and share the link here

@badijm
Copy link
Contributor

badijm commented Aug 10, 2020

@AndreiMaz #4963

@holydk holydk self-assigned this Oct 12, 2020
holydk pushed a commit that referenced this issue Oct 19, 2020
@holydk
Copy link
Contributor

holydk commented Oct 19, 2020

Closed #4919

@holydk holydk closed this as completed Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants