Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bestsellers report counts sales incorrectly #4956

Closed
RomanovM opened this issue Jul 31, 2020 · 2 comments
Closed

Bestsellers report counts sales incorrectly #4956

RomanovM opened this issue Jul 31, 2020 · 2 comments
Assignees
Labels
Milestone

Comments

@RomanovM
Copy link
Contributor

nopCommerce version: 4.30

I started to debug the code, at some point in the past someone added in the Category to the query for the best seller report and because of that left join it will count your sales 1 time for each category that product is in. in my case i had a few of my best sellers in two categories and there for my sales were doubled for them.
I would assume that sales for an order item should be counted only once, no matter how many categories that product is in.
While I just mention this bug for the best sellers report, it might be a good idea to make sure other reports do not have the same issue.

Steps to reproduce the problem: map a product to multiple categories, makes some sales and view the best sellers report.

Source: https://www.nopcommerce.com/en/boards/topic/85001/best-selling-report-counts-sales-incorrectly

@RomanovM RomanovM added the bug label Jul 31, 2020
@RomanovM RomanovM added this to the Version 4.40 milestone Jul 31, 2020
@YetAnotherDev
Copy link

I submitted this bug on the forum, please let me know if you have any issues reproducing it or if i can provide more information on this issue.

@holydk
Copy link
Contributor

holydk commented Aug 28, 2020

Closed #4956

@holydk holydk closed this as completed Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants