Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order CustomValuesXml #5250

Closed
SelectSystemsInternational opened this issue Dec 28, 2020 · 4 comments
Closed

Order CustomValuesXml #5250

SelectSystemsInternational opened this issue Dec 28, 2020 · 4 comments

Comments

@SelectSystemsInternational
Copy link

nopCommerce version: All

Regards the attribute order.CustomValuesXml
On the Customer Order Details page, the decoded values are associated with and displayed under the Billing Address heading
In the Order PDF the values are displayed separately under the Payment Method Details
In Admin Order Details the Custom Values are displayed separately under the Payment Method details

I use order.CustomValuesXml for storing details about the payment either:
The Payment Method type (in the case where there are multiple payment types for the one payment method)
For other payment methods order.CustomValuesXml is used to store a Payment Receipt number
I dont know how others may use it ?

I also do not know if there is a reason why order.CustomValuesXml are associated with the Billing Address on the Customer Order Details page ?
This attribute is more likely to be used to store information about the order rather than details related to the billing address.

I would like to recommend that the display of the order.CustomValuesXml be moved on the Customer Order Details page to under the Payment Details so that it is standardised in all three locations.

@SelectSystemsInternational
Copy link
Author

Any more thoughts on this change ?

@RomanovM
Copy link
Contributor

See also #3304

@RomanovM RomanovM added this to the Version 4.50 milestone Sep 2, 2021
@AndreiMaz AndreiMaz removed this from the Version 4.50 milestone Oct 8, 2021
@AndreiMaz AndreiMaz added this to the Version 4.60 milestone Nov 13, 2021
@RomanovM RomanovM self-assigned this May 17, 2022
@RomanovM RomanovM assigned skoshelev and unassigned RomanovM Nov 30, 2022
skoshelev added a commit that referenced this issue Nov 30, 2022
@skoshelev
Copy link
Contributor

Closed #5250

@SelectSystemsInternational
Copy link
Author

Suggestion that there now be a case to add a Type or DIsplay Location field and make it a Tuple <DisplayLocation, Key, Value>
So that the values can be linked to and displayed in the most approporaite location under either:

  1. BillingAddress - Billing Address related customer values
  2. ShippingAddress - Shipping Address related customer values
  3. Payment - For values associated with Payment i.e. Receipt number or Invoice Number
  4. Shipping - For values associated with Shipping i.e. Pickup Point

In a new Shipping plugin the Service Location for pickup of the order package with associated details as well as a customer Reciept Number are stored as customer order values - The details are now displayed under Payment but would be better if displayed under shipping

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants