Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review the use of events in the NewsLetterSubscription service #5300

Closed
RomanovM opened this issue Jan 25, 2021 · 1 comment
Closed

Review the use of events in the NewsLetterSubscription service #5300

RomanovM opened this issue Jan 25, 2021 · 1 comment
Assignees
@skoshelev
Labels
refactoring / source code
Milestone
Version 4.40

Comments

@RomanovM
Copy link
Contributor

RomanovM commented Jan 25, 2021 •
edited

nopCommerce version: develop

We moved the generic events publishing from services to the repository, but for some reason left for the above service.
We also have a separate EmailSubscribedEvent and EmailUnsubscribedEvent events for this.
This all leads to duplicate events and the impossibility of using them correctly in plugins. So, let's check and review using all of these events in the service.

Source: https://www.nopcommerce.com/en/boards/topic/90037/handleevententityinsertedeventnewslettersubscription-eventmessage-gets-called-twice
@RomanovM RomanovM added this to the Version 4.40 milestone Jan 25, 2021
skoshelev added a commit that referenced this issue Jan 26, 2021
@skoshelev
#5300 Removed unnecessary event publications
1d6d8cb
@skoshelev
Copy link
Contributor

Closed #5300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skoshelev skoshelev

Labels
refactoring / source code
Projects
None yet
Milestone
Version 4.40
Development

No branches or pull requests
2 participants
@RomanovM @skoshelev