Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an event to the " UpdateAsync" method #5504

Closed
AndreiMaz opened this issue Mar 6, 2021 · 3 comments
Closed

Add an event to the " UpdateAsync" method #5504

AndreiMaz opened this issue Mar 6, 2021 · 3 comments
Assignees
@skoshelev
Labels
refactoring / source code
Milestone
Version 4.40

Comments

@AndreiMaz
Copy link
Member

AndreiMaz commented Mar 6, 2021 •
edited

The UpdateAsync method does not take into account the publishEvent parameter and no event is being published -

nopCommerce/src/Libraries/Nop.Data/EntityRepository.cs

Line 377 in 9e9795d

public virtual async Task UpdateAsync(IList<TEntity> entities, bool publishEvent = true)

Source: https://www.nopcommerce.com/en/boards/topic/90152/nopcommerce-440-bug-fixes-and-improvements/page/5#281747

See PR: #5506
@AndreiMaz AndreiMaz added this to the Version 4.40 milestone Mar 6, 2021
@badijm
Copy link
Contributor

badijm commented Mar 7, 2021

Hi, I can pick this item.

@badijm badijm mentioned this issue Mar 7, 2021
Merged
@AndreiMaz
Copy link
Member Author

@skoshelev see #5506

skoshelev added a commit that referenced this issue Mar 9, 2021
@skoshelev
#5504 Added an event to the " UpdateAsync" method
f3d1171
@skoshelev
Copy link
Contributor

Thank you @badijm

Closed #5504

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skoshelev skoshelev

Labels
refactoring / source code
Projects
None yet
Milestone
Version 4.40
Development

No branches or pull requests
3 participants
@AndreiMaz @skoshelev @badijm