Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use comma-separated specification attribute values for ColorSquaresRgb #5543

Closed
RomanovM opened this issue Mar 17, 2021 · 1 comment
Closed

Don't use comma-separated specification attribute values for ColorSquaresRgb #5543

RomanovM opened this issue Mar 17, 2021 · 1 comment
Assignees
@purehaTime
Labels
refactoring / source code
Milestone
Version 4.50

Comments

@RomanovM
Copy link
Contributor

nopCommerce version: 4.40

In nopCommerce 4.40 the text of multiple specification values is comma-separated, but we noticed that the commas are added even if the values are "attribute squares" and not text. Here is a screenshot of how the product page is currently looking in DefaultClean theme - the layout is a bit messy.
We found the same issue on product details pages and on compare products pages.

BgGsXx6

Source: https://www.nopcommerce.com/boards/topic/90152/nopcommerce-440-bug-fixes-and-improvements/page/8#283216
@RomanovM RomanovM added this to the Version 4.50 milestone Mar 17, 2021
@RomanovM RomanovM assigned purehaTime and unassigned holydk Sep 14, 2021
RomanovM pushed a commit that referenced this issue Sep 20, 2021
@purehaTime
#5543 Don't use comma-separated specification attribute values for Co…
eff9b1d 
…lorSquaresRgb (#5827)

* Issue 5543 Don't use comma-separated specification attribute values for ColorSquaresRgb

* Issue 5543 Don't use comma-separated specification attribute values for ColorSquaresRgb
@purehaTime
Copy link
Contributor

Done with version 4.50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@purehaTime purehaTime

Labels
refactoring / source code
Projects
None yet
Milestone
Version 4.50
Development

No branches or pull requests
3 participants
@purehaTime @RomanovM @holydk