Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Length restriction on frontend inputs #6552

Closed
AndreiMaz opened this issue Jan 27, 2023 · 2 comments
Closed

Length restriction on frontend inputs #6552

AndreiMaz opened this issue Jan 27, 2023 · 2 comments

Comments

@AndreiMaz
Copy link
Member

AndreiMaz commented Jan 27, 2023

nopCommerce version: 4.60.1

All details at https://www.nopcommerce.com/en/boards/topic/96120/no-password-length-restriction-leads-to-denial-of-service

Let's investigate whether it can be used for any kind of attacks

Related work item: #6557

@skoshelev
Copy link
Contributor

We have a method SetStringPropertiesMaxLength that allows us to set a limit on the length of the field in accordance with the length in the database. We can consider using it not only in the administration area but also in the public store. Then we just need to set restrictions in the table structure.

@AndreiMaz
Copy link
Member Author

After some consideration we've decided not to implement this functionality out of the box and leave it for customization because the original work item is already implemented. The issue with hashing could be reproduced there only and it's not related to other inputs (e.g. first name, etc)

@AndreiMaz AndreiMaz closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2024
@AndreiMaz AndreiMaz removed this from the Version 4.80 milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants