Copying a product with attribute combinations results in incorrect StockQuantityHistory entry

[GordonBlahut]

I believe there is a bug in the ProductCopyService.CopyAttributesMappingAsync method at the call to _productService.AddStockQuantityHistoryEntryAsync on lines 371-373.

The combinationId parameter receives combination.Id, but I believe that combinationCopy.Id would be more appropriate. Currently, the resulting entry in the StockQuantityHistory table references the product copy's id but the original comination's id and this causes issues when trying to reconcile inventory history for products with attribute combinations.

nopCommerce/src/Libraries/Nop.Services/Catalog/CopyProductService.cs

Lines 341 to 373 in 98adab9

	var combinationCopy = new ProductAttributeCombination
	{
	ProductId = productCopy.Id,
	AttributesXml = newAttributesXml,
	StockQuantity = combination.StockQuantity,
	MinStockQuantity = combination.MinStockQuantity,
	AllowOutOfStockOrders = combination.AllowOutOfStockOrders,
	Sku = combination.Sku,
	ManufacturerPartNumber = combination.ManufacturerPartNumber,
	Gtin = combination.Gtin,
	OverriddenPrice = combination.OverriddenPrice,
	NotifyAdminForQuantityBelow = combination.NotifyAdminForQuantityBelow
	};
	await _productAttributeService.InsertProductAttributeCombinationAsync(combinationCopy);
	//picture
	var oldCombinationPictures = await _productAttributeService.GetProductAttributeCombinationPicturesAsync(combination.Id);
	foreach (var oldCombinationPicture in oldCombinationPictures)
	{
	if (!originalNewPictureIdentifiers.TryGetValue(oldCombinationPicture.PictureId, out var combinationPictureId))
	continue;
	await _productAttributeService.InsertProductAttributeCombinationPictureAsync(new ProductAttributeCombinationPicture
	{
	ProductAttributeCombinationId = combinationCopy.Id,
	PictureId = combinationPictureId
	});
	}
	//quantity change history
	await _productService.AddStockQuantityHistoryEntryAsync(productCopy, combination.StockQuantity,
	combination.StockQuantity,
	message: string.Format(await _localizationService.GetResourceAsync("Admin.StockQuantityHistory.Messages.CopyProduct"), product.Id), combinationId: combination.Id);

I would also argue there's a valid use case for wanting to copy a product and attribute combinations without copying any inventory information but that's a separate issue.

[parshan2]

You are absolutely right. This issue also causes an exception error when copying products with attribute combinations. I have also fixed two other parameter issues in the AddStockQuantityHistoryEntryAsync method call. I have just created an equivalent pull request for this.

[skoshelev]

Closed #7202