Refactor GetWareHouseByIdAsync method #6361
Conversation
|
By excepting this refactoring, does it now entangle one service to depend on the other.
…________________________________
From: Claude De-Tchambila ***@***.***>
Sent: Sunday, September 25, 2022 7:15:17 AM
To: nopSolutions/nopCommerce ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [nopSolutions/nopCommerce] Refactor GetWareHouseByIdAsync method (PR #6361)
Refactoring in connection with this issue #6348<#6348>
________________________________
You can view, comment on, or merge this pull request online at:
#6361
Commit Summary
* b17b0a8<b17b0a8> #6348 Refactor GetWareHouseByIdAsync method
File Changes
(3 files<https://github.com/nopSolutions/nopCommerce/pull/6361/files>)
* M src/Libraries/Nop.Services/Catalog/IProductService.cs<https://github.com/nopSolutions/nopCommerce/pull/6361/files#diff-f2f8aa19efe607bdface9b6a35d1946afdaa45acfda0a9c08781524c825f088a> (10)
* M src/Libraries/Nop.Services/Catalog/ProductService.cs<https://github.com/nopSolutions/nopCommerce/pull/6361/files#diff-bf27af985b3597768ed36895bf974c7a2b244833700fcec4bc1d48797b49e191> (13)
* M src/Presentation/Nop.Web/Areas/Admin/Factories/OrderModelFactory.cs<https://github.com/nopSolutions/nopCommerce/pull/6361/files#diff-0637f17576fc2feed9f11ed851abae308910bfe66fd339167653b21b52ce66bb> (2)
Patch Links:
* https://github.com/nopSolutions/nopCommerce/pull/6361.patch
* https://github.com/nopSolutions/nopCommerce/pull/6361.diff
—
Reply to this email directly, view it on GitHub<#6361>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKD4KOZBERVELEIYHPM5FHDWABM7LANCNFSM6AAAAAAQVDONEQ>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
It doesn't seem ideal to have a service that depends on another one. But what would the alternative be here? |
|
In my thinking they may be named the same but the separation is the service they belong to. A naming is just a name. I have not in recent times reviewed the nop code base to determine if there are many entanglements across service boundaries.
…________________________________
From: Claude De-Tchambila ***@***.***>
Sent: Sunday, September 25, 2022 2:14:30 PM
To: nopSolutions/nopCommerce ***@***.***>
Cc: Gregory Hays ***@***.***>; Comment ***@***.***>
Subject: Re: [nopSolutions/nopCommerce] Refactor GetWareHouseByIdAsync method (PR #6361)
By excepting this refactoring, does it now entangle one service to depend on the other.
…
________________________________ From: Claude De-Tchambila @.> Sent: Sunday, September 25, 2022 7:15:17 AM To: nopSolutions/nopCommerce @.> Cc: Subscribed @.> Subject: [nopSolutions/nopCommerce] Refactor GetWareHouseByIdAsync method (PR #6361<#6361>) Refactoring in connection with this issue #6348<#6348><#6348<https://github.com/nopSolutions/nopCommerce/issues/6348>>
________________________________ You can view, comment on, or merge this pull request online at: #6361<#6361> Commit Summary * b17b0a8<https://github.com/nopSolutions/nopCommerce/commit/b17b0a83b959c43e2e4b3afe7d5d8b1e4e9a8ea7><b17b0a8<https://github.com/nopSolutions/nopCommerce/pull/6361/commits/b17b0a83b959c43e2e4b3afe7d5d8b1e4e9a8ea7>> #6348<#6348> Refactor GetWareHouseByIdAsync method File Changes (3 fileshttps://github.com/nopSolutions/nopCommerce/pull/6361/files) * M src/Libraries/Nop.Services/Catalog/IProductService.cshttps://github.com/nopSolutions/nopCommerce/pull/6361/files#diff-f2f8aa19efe607bdface9b6a35d1946afdaa45acfda0a9c08781524c825f088a (10) * M src/Libraries/Nop.Services/Catalog/ProductService.cshttps://github.com/nopSolutions/nopCommerce/pull/6361/files#diff-bf27af985b3597768ed36895bf974c7a2b244833700fcec4bc1d48797b49e191 (13) * M src/Presentation/Nop.Web/Areas/Admin/Factories/OrderModelFactory.cshttps://github.com/nopSolutions/nopCommerce/pull/6361/files#diff-0637f17576fc2feed9f11ed851abae308910bfe66fd339167653b21b52ce66bb (2) Patch Links: * https://github.com/nopSolutions/nopCommerce/pull/6361.patch * https://github.com/nopSolutions/nopCommerce/pull/6361.diff — Reply to this email directly, view it on GitHub<#6361<#6361>>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKD4KOZBERVELEIYHPM5FHDWABM7LANCNFSM6AAAAAAQVDONEQ. You are receiving this because you are subscribed to this thread.Message ID: @.>
It doesn't seem ideal to have a service that depends on another one. But what would the alternative be here?
—
Reply to this email directly, view it on GitHub<#6361 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKD4KO5QO3Q4A5TUNAWYUETWAC6DNANCNFSM6AAAAAAQVDONEQ>.
You are receiving this because you commented.Message ID: ***@***.***>
|
|
Hi @ChrisClaude. Thank you for your help. |
Refactoring in connection with this issue #6348