Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage for AddressService #7014

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Improve test coverage for AddressService #7014

merged 2 commits into from
Apr 24, 2024

Conversation

apurvai007
Copy link
Contributor

This pull request addresses the following:

  1. Adds concise unit tests for the IsAddressValidAsync method in the AddressService class.
  2. Focus is on validating essential fields (FirstName, LastName, Email).

Changes Made :

  1. Added tests for the IsAddressValidAsync method.
  2. Tests cover scenarios with valid and invalid addresses.
  3. Focused on independent fields (FirstName, LastName, Email) to ensure robust validation.

Based off this issue : #405

@skoshelev skoshelev merged commit fa8479f into nopSolutions:develop Apr 24, 2024
@skoshelev
Copy link
Contributor

Hi @apurvai007. Thank you for your help

@exileDev exileDev added this to the Version 4.70 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@skoshelev skoshelev

Labels
refactoring / source code
Projects
None yet
Milestone
Version 4.70
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apurvai007 @skoshelev @exileDev