Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove wrong parameters #413

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

JonathanLoscalzo
Copy link
Contributor

What changed?

Arguments removed from create_spoke_role_stack at wizard.py

Rationale

Due to the python typing nature, when we refactor some arguments got changed

How was it tested?

  • Unit Tests
  • Functional Tests
  • Manually Verified

@JonathanLoscalzo JonathanLoscalzo linked an issue May 16, 2023 that may be closed by this pull request
@JonathanLoscalzo JonathanLoscalzo self-assigned this May 16, 2023
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09 ⚠️

Comparison is base (f711e1f) 85.28% compared to head (b92441d) 85.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   85.28%   85.20%   -0.09%     
==========================================
  Files          98       98              
  Lines       10711    10711              
==========================================
- Hits         9135     9126       -9     
- Misses       1576     1585       +9     
Flag Coverage Δ
functional_tests 66.77% <ø> (-0.30%) ⬇️
functional_tests_config_discovery 47.00% <ø> (-0.05%) ⬇️
unit_tests 75.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@Will-NOQ Will-NOQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonathanLoscalzo JonathanLoscalzo merged commit 8b49a1c into main May 16, 2023
@JonathanLoscalzo JonathanLoscalzo deleted the fix/en-2021-hub_role_stack_name branch May 16, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hub_Role_stack_Name
2 participants