Skip to content

Commit

Permalink
♻ Pass PositionObserver as service builder directly (ampproject#20975)
Browse files Browse the repository at this point in the history
`registerServiceBuilderForDoc` already expects constructors so we can pass the classname without a wrapper fn.
  • Loading branch information
alanorozco authored and Noran Azmy committed Mar 22, 2019
1 parent a716e9a commit 4892629
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/service/position-observer/position-observer-impl.js
Expand Up @@ -206,7 +206,5 @@ export class PositionObserver {
* @param {!../ampdoc-impl.AmpDoc} ampdoc
*/
export function installPositionObserverServiceForDoc(ampdoc) {
registerServiceBuilderForDoc(ampdoc, 'position-observer', () => {
return new PositionObserver(ampdoc);
});
registerServiceBuilderForDoc(ampdoc, 'position-observer', PositionObserver);
}

0 comments on commit 4892629

Please sign in to comment.