[amp-list] resize amp-list on viewport resize experiment (ampproject#…

…19946) * Draft changes for toggling amp-list height on orientation change * Update experiment name
noranazmy · Mar 22, 2019 · 5f7b2e8 · 5f7b2e8
1 parent e2ece46
commit 5f7b2e8
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/extensions/amp-list/0.1/amp-list.js b/extensions/amp-list/0.1/amp-list.js
@@ -229,6 +229,13 @@ export class AmpList extends AMP.BaseElement {
     if (placeholder) {
       this.attemptToFit_(placeholder);
     }
+
+    if (isExperimentOn(this.win, 'amp-list-viewport-resize')) {
+      this.getViewport().onResize(() => {
+        this.attemptToFit_(dev().assertElement(this.container_));
+      });
+    }
+
     return this.fetchList_();
   }
 
@@ -668,6 +675,9 @@ export class AmpList extends AMP.BaseElement {
    * @private
    */
   attemptToFit_(target) {
+    if (this.element.getAttribute('layout') == Layout.CONTAINER) {
+      return;
+    }
     this.measureElement(() => {
       const scrollHeight = target./*OK*/scrollHeight;
       const height = this.element./*OK*/offsetHeight;

diff --git a/tools/experiments/experiments.js b/tools/experiments/experiments.js
@@ -408,6 +408,12 @@ const EXPERIMENTS = [
     spec: 'https://github.com/ampproject/amphtml/issues/10837',
     cleanupIssue: 'https://github.com/ampproject/amphtml/issues/XXXXX',
   },
+  {
+    id: 'amp-list-viewport-resize',
+    name: 'Enables amp-list to resize on viewport resize',
+    spec: 'https://github.com/ampproject/amphtml/issues/19945',
+    cleanupIssue: 'https://github.com/ampproject/amphtml/issues/19945',
+  },
 ];
 
 if (getMode().localDev) {