Skip to content

Commit

Permalink
馃悰Wait for element to be upgraded before mutate (ampproject#20943)
Browse files Browse the repository at this point in the history
  • Loading branch information
alanorozco authored and Noran Azmy committed Mar 22, 2019
1 parent 7aea578 commit bc7b563
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions extensions/amp-auto-lightbox/0.1/amp-auto-lightbox.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,10 @@ import {AmpEvents} from '../../../src/amp-events';
import {AutoLightboxEvents} from '../../../src/auto-lightbox';
import {CommonSignals} from '../../../src/common-signals';
import {Services} from '../../../src/services';
import {closestAncestorElementBySelector} from '../../../src/dom';
import {
closestAncestorElementBySelector,
whenUpgradedToCustomElement,
} from '../../../src/dom';
import {dev} from '../../../src/log';
import {getMode} from '../../../src/mode';
import {toArray} from '../../../src/types';
Expand Down Expand Up @@ -295,7 +298,9 @@ export class Mutation {
* @return {!Promise}
*/
static mutate(ampEl, mutator) {
return ampEl.getImpl().then(impl => impl.mutateElement(mutator));
return whenUpgradedToCustomElement(ampEl)
.then(ampEl => ampEl.getImpl())
.then(impl => impl.mutateElement(mutator));
}
}

Expand Down

0 comments on commit bc7b563

Please sign in to comment.