Skip to content

Commit

Permalink
Remove bundle size check from pre-push hook (ampproject#19993)
Browse files Browse the repository at this point in the history
* Skip check if no runtime files were touched

* Apply this to pre-push builds only

* Revert last 2 commits

* Straight up delete bundle size check from pre-push hook
  • Loading branch information
cathyxz authored and Noran Azmy committed Mar 22, 2019
1 parent 2f5338f commit cd4a1e1
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions build-system/default-pre-push
Expand Up @@ -25,17 +25,12 @@
GREEN() { echo -e "\033[0;32m$1\033[0m"; }
CYAN() { echo -e "\033[0;36m$1\033[0m"; }

GULP_BUNDLE_SIZE="gulp bundle-size"
GULP_LINT_LOCAL="gulp lint --local-changes"
GULP_TEST_LOCAL="gulp test --local-changes --headless"

echo $(GREEN "Running") $(CYAN "pre-push") $(GREEN "hooks. (Run") $(CYAN "git push --no-verify") $(GREEN "to skip them.)")
echo -e "\n"

echo $(GREEN "Running") $(CYAN "$GULP_BUNDLE_SIZE")
eval $GULP_BUNDLE_SIZE || exit 1
echo -e "\n"

echo $(GREEN "Running") $(CYAN "$GULP_LINT_LOCAL")
eval $GULP_LINT_LOCAL || exit 1
echo -e "\n"
Expand Down

0 comments on commit cd4a1e1

Please sign in to comment.