Patch react-awesome-styled-grid

[nowyDEV]

What

• Patched usage of global in react-awesome-styled-grid, it was causing problems in browser & test environment

Compatibility

• Does this change maintain backward compatibility?

Screenshots

Before

After

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[aws-amplify-eu-west-1]

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-459.du3gff836giqw.amplifyapp.com

[roertbb]

Could you elaborate on problems in browser & test environment?

From what I see, root cause of the problem comes from https://github.com/donavon/use-event-listener.

I'm aware that sometimes patching deps may be necessary, but I'd rather use it as a last resort and leave extensive comment why it's done to have full context on how to get rid of it in the future

[nowyDEV]

Could you elaborate on problems in browser & test environment?

From what I see, root cause of the problem comes from https://github.com/donavon/use-event-listener.

I'm aware that sometimes patching deps may be necessary, but I'd rather use it as a last resort and leave extensive comment why it's done to have full context on how to get rid of it in the future

It uses global that becomes undefined both in the browser & in test environment

santosfrancisco/react-awesome-styled-grid#138
vitejs/vite#728 (comment)

This causes test failures with vitest (cannot add event listener to undefined)

react-awesome-styled-grid seems to no longer be actively maintained (last release september 2021), the risk of update that will break the patch is unlikely (it's pretty easy to modify the patch anyway)

[roertbb]

Could you elaborate on problems in browser & test environment?
From what I see, root cause of the problem comes from https://github.com/donavon/use-event-listener.
I'm aware that sometimes patching deps may be necessary, but I'd rather use it as a last resort and leave extensive comment why it's done to have full context on how to get rid of it in the future

It uses global that becomes undefined both in the browser & in test environment

santosfrancisco/react-awesome-styled-grid#138 vitejs/vite#728 (comment)

This causes test failures with vitest (cannot add event listener to undefined)

react-awesome-styled-grid seems to no longer be actively maintained (last release september 2021), the risk of update that will break the patch is unlikely (it's pretty easy to modify the patch anyway)

Thanks for detailed context 😉
From what I see, vitest seems to be able to configure global API for tests - see: https://vitest.dev/config/#globals.
Same for vite it seems that are other workarounds that are not patching libs - aws-amplify/amplify-js#9639 (comment).
I don't wanna block the PR, since 2 other guys approved it, but I feel we may have similar problems with other libs and maybe the links above may suggest alternative solution to tackle the problem 😉