Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boilerplate file structure #13

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Boilerplate file structure #13

merged 7 commits into from
Dec 5, 2023

Conversation

mxwt00
Copy link
Collaborator

@mxwt00 mxwt00 commented Nov 20, 2023

Structured code into separate files for each command;
moved logic for executing commands into these files

Copy link
Contributor

@juliuskoskela juliuskoskela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@juliuskoskela
Copy link
Contributor

You need to sign the commits. Here's the guide https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

After setting it up you should be able to do

git rebase --exec 'git commit --amend --no-edit -n -S' -i <rebase start commit sha>

...or similar. Might require a force push after.

Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Signed-off-by: Max Winter <maxwinter00@gmail.com>
Copy link
Contributor

@Danielprobst22 Danielprobst22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mxwt00 mxwt00 merged commit 56e35e2 into main Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants