Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex search and github integration status bar #87

Closed
wants to merge 3 commits into from

Conversation

Voultapher
Copy link

Having used this theme for 3+ years now, first of all, thank your very much for this awesome theme. Atom changed over the years and introduces several smaller things that 'broke' certain aspects of this theme. It was still very usable, but those small things annoyed me enough I decided I'd fix them. I've been using a version with these changes for over a month now and didn't notice any major regression, rather the opposite, it feels more polished this way.

I'm not a CSS expert, so I'm totally open to alternative ways to achieving the same UX.

Signed-off-by: Lukas Bergdoll <lukas.bergdoll@gmail.com>
Also add default pointer cursor to buttons
Button mixin now has less implications about usage, by taking
the background color as parameter rather than implicitly using
transparency which causes a whole set of problems.
Uniform white style, and cursor click.
Remove weird double box in expand commit message
@Voultapher
Copy link
Author

Friendly ping, I'll close this PR in 2 weeks if there is no feedback.

@arcticicestudio
Copy link
Contributor

Hi @Voultapher 👋, first of thanks for your contribution 👍
Thanks for your patience, the large amount of tasks for the Nord project are really time consuming and my free time to work on all my OSS projects is limited. There are currently 60+ port project requests in the backlog and a massive amount of 350+ issues & PRs, not including support and help tasks per repository and requests from various communication channels like Twitter, the /r/nordtheme subreddit or just emails. The data transition of all port projects to the official website and documentations is still a focused job to finally reduce the maintenance overhead, create a „single source of truth“ and increase the overall project quality :octocat:

Anyway, I'm well aware of all the activities in the repositories through my project management tools and the GitHub notifications, but the fact that I personally migrated away from Atom some years ago is also a reason why I don't notice such incompatibilities when Atom pushes new updates.
As soon as there is finally time again to process all the requests I can also review this PR. I often see people closing issues/PRs for no real reason in projects across GitHub when there is no activity in a short time, but as far as I know GitHub does not charge anyone for how long a issue/PR is open (sorry, sometimes there has to be a bit of sarcasm 😜). Of course you're free to close this PR, but it would be a shame if the time and effort invested in it had been wasted.

@Voultapher
Copy link
Author

Voultapher commented Jun 6, 2021

I appreciate your situation, open source is wildly underfunded and I it's fully up to you where you invest your time. I never paid for your work so what claim of your time do I have. Of course it's nice if contributions are embraced. From experience PRs that linger for too long are unhealthy. Plus I've recently moved away from Atom myself so I have limited remaining interest in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants