Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cider evaluation result in terminal #71

Merged
merged 1 commit into from Jan 6, 2020
Merged

Fix cider evaluation result in terminal #71

merged 1 commit into from Jan 6, 2020

Conversation

fmnoise
Copy link
Contributor

@fmnoise fmnoise commented Apr 6, 2019

Closes #70

@fmnoise fmnoise changed the title Fix cider result in terminal Fix cider evaluation result in terminal Apr 6, 2019
@arcticicestudio
Copy link
Contributor

arcticicestudio commented Jan 6, 2020 •
edited

Hi @fmnoise 👋, thanks for your contribution 👍
Sorry for this really long reply/review delay, but unfortunately it's due to my little free time 😒

Could you please post a way to reproduce the actual problem? I'd like to test the way the unspecified keyword for the background color behaves in different rendering modes.

@arcticicestudio arcticicestudio added this to the 0.5.0 milestone Jan 6, 2020
@arcticicestudio arcticicestudio mentioned this pull request Jan 6, 2020
Closed
@fmnoise
Copy link
Contributor Author

fmnoise commented Jan 6, 2020 •
edited

@arcticicestudio
I order to reproduce you can eval some clojure code using https://github.com/clojure-emacs/cider
Background and font in evaluation result overlay has the same (or very similar) color so it becomes unreadable
Probably that's because of https://github.com/clojure-emacs/cider/blob/f6ac1594eb20b0d3b9f9b7601e3d2708346dc0bb/cider-overlays.el#L35
It's in terminal, I haven't checked how that works in Emacs GUI version. I used iterm2, nord-iterm2 is installed.

@arcticicestudio arcticicestudio changed the title Fix cider evaluation result in terminal Fix cider evaluation result in terminal Jan 6, 2020
@arcticicestudio arcticicestudio merged commit 995d842 into nordtheme:develop Jan 6, 2020
@arcticicestudio arcticicestudio removed their request for review January 6, 2020 20:06
arcticicestudio pushed a commit that referenced this pull request Jan 8, 2020
@fmnoise @arcticicestudio
Fix cider evaluation result in terminal (#71)
51ce3d3 
When running the "Cider" package [1] in Emacs GUI mode through iTerm2 on
macOS, the background and font color in the evaluation result overlay
was the same (or very similar) color so it became unreadable.
Probably that's because of defined `cider-result-overlay-face` face [2]
and a difference in the rendering engine of iTerm2.

To prevent this problem, the background color has been removed.

[1]: https://github.com/clojure-emacs/cider
[2]: https://github.com/clojure-emacs/cider/blob/f6ac1594eb20b0d3b9f9b7601e3d2708346dc0bb/cider-overlays.el#L35

Closes GH-70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svengreb svengreb svengreb approved these changes

Assignees
No one assigned
Labels
context-package-support context-syntax scope-compatibility scope-ux type-feature
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

cider evaluation result looks unreadable in terminal
3 participants
@fmnoise @arcticicestudio @svengreb