Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove VertSplit's background #132

Closed
huyvohcmc opened this issue Jul 6, 2018 · 3 comments · Fixed by #153
Closed

Remove VertSplit's background #132

huyvohcmc opened this issue Jul 6, 2018 · 3 comments · Fixed by #153
Labels
context-config context-ui scope-ux type-feature
Milestone
version-0.11.0

Comments

@huyvohcmc
Copy link

Can we make the background of VertSplit to be the same color of the window's background? I don't see any reason why we should make the VertSplit looks bold and thick, it actually takes a lot of space in small laptops when you splitting more than 2 windows.
@viniarck
Copy link

+1.

I also overwrote it with autocmd ColorScheme nord hi VertSplit guibg=#2E3440 guifg=#434C5E

@arcticicestudio arcticicestudio added this to the 0.11.0 milestone Apr 13, 2019
@arcticicestudio arcticicestudio self-assigned this Apr 13, 2019
arcticicestudio added a commit that referenced this issue Apr 14, 2019
@arcticicestudio
Add theme config for bolder vertical split line
1ddc782 
Previously the `VertSplit` (1) (`:help VertSplit`) key used `nord1` as
background color by default making the line appear to be very lumpy.
This commit changes this style to use `nord0` as bavkground instead to
visually merge with the background so only the separator charaters are
a visual indiciator for the split line whih makes it look more
lightweight and unclutters the overall appeareance.

To allow user who liked the previous implementation to keep the style
this commit also adds a new `nord_bold_vertical_split_line` theme config
that can be assigned to `1` to achieve the legacy design.

The README also include information and hints how to change the
separator character by customizing Vim's `fillchars` (2)
(`:help fillchars`) variable.

References:
  (1) http://vimdoc.sourceforge.net/htmldoc/syntax.html#hl-VertSplit
  (2) http://vimdoc.sourceforge.net/htmldoc/options.html#'fillchars'

GH-132
@arcticicestudio arcticicestudio mentioned this issue Apr 14, 2019
Merged
@arcticicestudio
Copy link
Contributor

Hi @huyvohcmc and @viniarck 👋
Thanks for your contributions 👍

I've been too busy with my "real" life and the development of the official Nord website to work on the massive amount of issues/PRs that were submitted each day for all of Nord's port projects.

I've submitted #153 that changes the style of the vertical split line and also adds a new theme config to allow users to use the legacy style. It will be merged into the next release version.

With base editor background (default)

let g:nord_bold_vertical_split_line = 1

With enabled bold nord1 background

@viniarck
Copy link

Thanks @arcticicestudio. Appreciated that!

arcticicestudio added a commit that referenced this issue Apr 15, 2019
@arcticicestudio
Merge pull request #153 from arcticicestudio/feature/gh-132-bold-vert…
9059d7d 
…ical-split-line-config

Theme config for bolder vertical split line
@arcticicestudio arcticicestudio removed their assignment Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-config context-ui scope-ux type-feature
Projects
None yet
Milestone
version-0.11.0
Development

Successfully merging a pull request may close this issue.

Theme config for bolder vertical split line nordtheme/vim
3 participants
@viniarck @arcticicestudio @huyvohcmc