Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contrast of brackets is counterintuitive #75

Closed
volo1st opened this issue Nov 21, 2017 · 1 comment · Fixed by #78
Closed

Contrast of brackets is counterintuitive #75

volo1st opened this issue Nov 21, 2017 · 1 comment · Fixed by #78

Comments

@volo1st
Copy link

volo1st commented Nov 21, 2017

The contrast (or colour intensity) for brackets under the cursor annoyed me a lot recently.
The problem as you can see from the screenshots below is: when you moving the cursor, the bracket will blink between frame 1 and frame 2. Even worse, frame 1 comes first and has a darker colour without other visual indications. So my eyes are distracted to focus on the matching bracket instead of the bracket at the cursor position.

image
Nord bracket under cursor frame 1
image
Nord bracket under cursor frame 2

In contrast, Gruvbox set it in a more intuitive way:

image
Gruvbox bracket under cursor frame 1
image
Gruvbox bracket under cursor frame 2

Probably you guys could consider updating the colour a bit?
Thank you for making such a great suites of colour schemes!

@arcticicestudio
Copy link
Contributor

Thanks for your contribution 👍 and sorry for my late reply.

I've been a bit confused about the light border around the matching bracket on the frame 1 screenshot of the Gruvbox theme. I've checked their code and the vim documentations again to see if I never noticed that Vim supports borders for elements which would solve the problem immediately, but then I recognized that it is just the Block cursor type instead of IBeam which is shown as a empty box when the terminal is not focused 😆

Anyway, I've posted my review of your PR in #78.

@arcticicestudio arcticicestudio added this to the 0.7.0 milestone Dec 28, 2017
arcticicestudio added a commit to volo1st/nord-vim that referenced this issue Dec 30, 2017
A more detailed review of this change can be found in the PR thread:
nordtheme#78 (review)

The changes from the previous commit are good, but there haven still
been some edge cases which had to be coverd. It applied for the "gui"
mode or when the "termguicolors" option is set, but the "cterm" mode is
still affected by the problem (1).

When changing the cterm definitions it had to be keept in mind that there
is no "nord0_term" variable. If set to "NONE" (to make it kind of
"transparent" and use the main background color) there is another edge
case when the "cursorline" option is enabled so only the foreground color
of the matching elements would change to "nord8" (2, 3).

To optimally improve the highlighting for both "gui" and "cterm" mode
"nord3" will be used as background color for the matching element which
doesn't conflict with the "cursorline" color and also stands out in order
to see the matching element (4, 5, 6)

References:

  (1) https://user-images.githubusercontent.com/7836623/34409455-3370fada-ebca-11e7-9ed8-d83c3a9c5055.png
  (2) https://user-images.githubusercontent.com/7836623/34409493-6221fdd4-ebca-11e7-97c4-703ca9e5198a.png
  (3) https://user-images.githubusercontent.com/7836623/34409508-74f913a2-ebca-11e7-8dd2-896ac809e23b.png
  (4) https://user-images.githubusercontent.com/7836623/34409567-d8c64bfc-ebca-11e7-919a-1a40cf146084.png
  (5) https://user-images.githubusercontent.com/7836623/34409570-dec9c1aa-ebca-11e7-8e68-32b79ec0d7c9.png
  (6) https://user-images.githubusercontent.com/7836623/34409581-eddcefc8-ebca-11e7-9ab7-29b80704d836.gif

nordthemeGH-75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants