Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bracket color in VSCode 1.60 #225

Closed
roosephu opened this issue Sep 11, 2021 · 1 comment · Fixed by #231
Closed

Bracket color in VSCode 1.60 #225

roosephu opened this issue Sep 11, 2021 · 1 comment · Fixed by #231

Comments

@roosephu
Copy link

The most recent update to VSCode brings a new feature, which colorizes brackets fast and also allows customization. Is it possible to incorporate the feature with the wonderful Nord theme? Thanks!

@arcticicestudio
Copy link
Contributor

Hi @roosephu 👋, thanks for your contribution 👍
The new color tokens will be added to Nord, but please note that bracket pair colorization is a feature that does not go well with the design concepts of Nord and the recommendation is therefore to not enable it. Of course this is always a personal preference and the feature be used as you wish, but note that the bracket colors defined by the Nord theme won't be changed on request but users can simply customize it on their own.

arcticicestudio added a commit that referenced this issue Sep 19, 2021
VS Code 1.60 [1] (August 2021) introduced native, high performance
bracket pair colorization [2] (opt-in via
`editor.bracketPairColorization.enabled` setting) to address performance
issues of popular extensions.
The color tokens have been added and adjusted to match Nord's theme
style:

- `statusBarItem.warningBackground` - the background color used for
  warning items in the status bar that stand out from other status bar
  entries to indicate warning conditions.
- `statusBarItem.warningForeground` - the foreground color used for
  warning items in the status bar that stand out from other status bar
  entries to indicate warning conditions.

Note that bracket pair colorization is a feature that does not go well
with the design concepts of Nord and the recommendation is therefore to
not enable it. Of course this is always a personal preference and the
feature be used as you wish, but note that the bracket colors defined by
the Nord theme won't be changed on request but users can simply
customize it on their own [3].

[1]: https://code.visualstudio.com/updates/v1_60
[2]: https://code.visualstudio.com/updates/v1_60#_high-performance-bracket-pair-colorization
[3]: https://www.nordtheme.com/docs/ports/visual-studio-code/customization

Co-authored-by: Sven Greb <development@svengreb.de>

GH-225
arcticicestudio added a commit that referenced this issue Sep 19, 2021
VS Code 1.60 [1] (August 2021) introduced native, high performance
bracket pair colorization [2] (opt-in via
`editor.bracketPairColorization.enabled` setting) to address performance
issues of popular extensions.
The color tokens have been added and adjusted to match Nord's theme
style:

- `statusBarItem.warningBackground` - the background color used for
  warning items in the status bar that stand out from other status bar
  entries to indicate warning conditions.
- `statusBarItem.warningForeground` - the foreground color used for
  warning items in the status bar that stand out from other status bar
  entries to indicate warning conditions.

Note that bracket pair colorization is a feature that does not go well
with the design concepts of Nord and the recommendation is therefore to
not enable it. Of course this is always a personal preference and the
feature be used as you wish, but note that the bracket colors defined by
the Nord theme won't be changed on request but users can simply
customize it on their own [3].

[1]: https://code.visualstudio.com/updates/v1_60
[2]: https://code.visualstudio.com/updates/v1_60#_high-performance-bracket-pair-colorization
[3]: https://www.nordtheme.com/docs/ports/visual-studio-code/customization


Co-authored-by: Sven Greb <development@svengreb.de>

Coses GH-225
arcticicestudio added a commit that referenced this issue Sep 25, 2021
VS Code 1.60 [1] (August 2021) introduced native, high performance
bracket pair colorization [2] (opt-in via
`editor.bracketPairColorization.enabled` setting) to address performance
issues of popular extensions.
The color tokens have been added and adjusted to match Nord's theme
style:

- `statusBarItem.warningBackground` - the background color used for
  warning items in the status bar that stand out from other status bar
  entries to indicate warning conditions.
- `statusBarItem.warningForeground` - the foreground color used for
  warning items in the status bar that stand out from other status bar
  entries to indicate warning conditions.

Note that bracket pair colorization is a feature that does not go well
with the design concepts of Nord and the recommendation is therefore to
not enable it. Of course this is always a personal preference and the
feature be used as you wish, but note that the bracket colors defined by
the Nord theme won't be changed on request but users can simply
customize it on their own [3].

[1]: https://code.visualstudio.com/updates/v1_60
[2]: https://code.visualstudio.com/updates/v1_60#_high-performance-bracket-pair-colorization
[3]: https://www.nordtheme.com/docs/ports/visual-studio-code/customization


Co-authored-by: Sven Greb <development@svengreb.de>

Coses GH-225
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants