Color tokens for bracket pair colorization #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VS Code 1.60 [1] (August 2021) introduced native, high performance bracket pair colorization [2] (opt-in via `editor.bracketPairColorization.enabled` setting) to address performance issues of popular extensions. The color tokens have been added and adjusted to match Nord's theme style: - `statusBarItem.warningBackground` - the background color used for warning items in the status bar that stand out from other status bar entries to indicate warning conditions. - `statusBarItem.warningForeground` - the foreground color used for warning items in the status bar that stand out from other status bar entries to indicate warning conditions. Note that bracket pair colorization is a feature that does not go well with the design concepts of Nord and the recommendation is therefore to not enable it. Of course this is always a personal preference and the feature be used as you wish, but note that the bracket colors defined by the Nord theme won't be changed on request but users can simply customize it on their own [3]. [1]: https://code.visualstudio.com/updates/v1_60 [2]: https://code.visualstudio.com/updates/v1_60#_high-performance-bracket-pair-colorization [3]: https://www.nordtheme.com/docs/ports/visual-studio-code/customization Co-authored-by: Sven Greb <development@svengreb.de> GH-225
svengreb
approved these changes
Sep 19, 2021
arcticicestudio
deleted the
feature/gh-225-color-tokens-bracket-pair-colorization
branch
arcticicestudio
added a commit
that referenced
this pull request
Sep 25, 2021
VS Code 1.60 [1] (August 2021) introduced native, high performance bracket pair colorization [2] (opt-in via `editor.bracketPairColorization.enabled` setting) to address performance issues of popular extensions. The color tokens have been added and adjusted to match Nord's theme style: - `statusBarItem.warningBackground` - the background color used for warning items in the status bar that stand out from other status bar entries to indicate warning conditions. - `statusBarItem.warningForeground` - the foreground color used for warning items in the status bar that stand out from other status bar entries to indicate warning conditions. Note that bracket pair colorization is a feature that does not go well with the design concepts of Nord and the recommendation is therefore to not enable it. Of course this is always a personal preference and the feature be used as you wish, but note that the bracket colors defined by the Nord theme won't be changed on request but users can simply customize it on their own [3]. [1]: https://code.visualstudio.com/updates/v1_60 [2]: https://code.visualstudio.com/updates/v1_60#_high-performance-bracket-pair-colorization [3]: https://www.nordtheme.com/docs/ports/visual-studio-code/customization Co-authored-by: Sven Greb <development@svengreb.de> Coses GH-225
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #225
VS Code 1.60 (August 2021) introduced native, high performance bracket pair colorization (opt-in via
editor.bracketPairColorization.enabledsetting) to address performance issues of popular extensions.The color tokens will be added and adjusted to match Nord's theme style:
statusBarItem.warningBackground— the background color used for warning items in the status bar that stand out from other status bar entries to indicate warning conditions.statusBarItem.warningForeground— the foreground color used for warning items in the status bar that stand out from other status bar entries to indicate warning conditions.Note that bracket pair colorization is a feature that does not go well with the design concepts of Nord and the recommendation is therefore to not enable it. Of course this is always a personal preference and the feature be used as you wish, but note that the bracket colors defined by the Nord theme won't be changed on request but users can simply customize it on their own.
Preview