[NO-3155] Fix usage of pranks in functions to make suite work with foundry@nightly

[jaycenhorton]

These changes fixes our integration with the latest versions of foundry. It seems something changed within the foundry stack that broke some of our test suites. The problematic test suites were all starting pranks in setUp functions without also calling stopPrank before the setUp function ended. It's unclear exactly why this broke (i suspect it's related to the changes in the revm dependency that was recently updated, but that's just a guess). Nonetheless it's a lot cleaner and easier to debug if we are using prank in more limited contexts (otherwise it can be hard to figure out what address is the currently active address, and this is especially true given that setup and test functions are initiated from two separate contexts IIRC).

The primary fix is outlined in this comment

I created a new issue in the foundry repo here

[swarmia]

✅  Linked to Task NO-3155 · Restore Foundry version to 'nightly' for github workflow

[amiecorso]

nice work figuring this out

[amiecorso]

I resolved all the conversations because I wanted this to automerge so I can pull it in to my priceMultiple PR but I left some responses