Add PipeWire support #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Words cannot describe how cursed some of the code I just wrote are. |
|
Current issues:
|
noriah
requested changes
Dec 21, 2022
lawl/* repositories seem to have been deleted. This commit fixes that.
diamondburned
force-pushed
the
pa-fix
branch
5 times, most recently
from
aa5602c
to
1375439
Compare
diamondburned
force-pushed
the
pa-fix
branch
from
1375439
to
39a4765
Compare
noriah
requested changes
Dec 24, 2022
| dst[n%framesz][n/framesz] = reader.next() | ||
| } | ||
| mu.Unlock() | ||
| sampleDuration := time.Duration( |
There was a problem hiding this comment.
currently the way the buffer is read means this will sometimes be too short. can we double this (or just 1.5x) for now and fix it properly later with some refactoring?
There was a problem hiding this comment.
Yeah, I made it so that it's 2x until the read expires once, then it's 1x for all future deadlines until it's sending samples again.
diamondburned
force-pushed
the
pa-fix
branch
from
39a4765
to
81e4318
Compare
noriah
approved these changes
Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
gr -b pipewire -d 'he400i-rtings-sink.eq'