Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use findstr instead of grep in CMakeList.txt for Windows #120

Merged
merged 1 commit into from Jan 26, 2022
Merged

Use findstr instead of grep in CMakeList.txt for Windows #120

merged 1 commit into from Jan 26, 2022

Conversation

maximecharriere
Copy link
Contributor

Problem

grep is a Unix command, so we need to install it on Windows.

Solution

The findstr command do the same on Windows. I modified the CMakeList.txt so that it calls the correct command.

Issue solved

@ethzasl-jenkins
Copy link

Can one of the admins verify this patch?

@pomerlef
Copy link
Collaborator

ok to test

@pomerlef
Copy link
Collaborator

Thanks for the patch!

@pomerlef pomerlef merged commit 6ba32b2 into norlab-ulaval:master Jan 26, 2022
@maximecharriere maximecharriere deleted the patch-1 branch January 26, 2022 16:38
@maximecharriere maximecharriere mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomerlef pomerlef pomerlef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maximecharriere @ethzasl-jenkins @pomerlef