Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmake package config helpers #128

Merged
merged 4 commits into from Jan 31, 2024
Merged

Cmake package config helpers #128

merged 4 commits into from Jan 31, 2024

Conversation

boxanm
Copy link
Contributor

@boxanm boxanm commented Nov 24, 2023

  1. Update Cmake version
  2. Use CMakePackageConfigHelpers to generate CMake config and version files
  3. Fill libnabo_INCLUDE_DIRS and libnabo_LIBRARIES variables

Copy link
Contributor

@simonpierredeschenes simonpierredeschenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! There is only one minor comment to address. Also, I was wondering, did you test to make sure it is still possible to refer to the libnabo target in a modern cmake way in dependent projects (e.g., target_link_libraries(my_executable libnabo::nabo))?

README.md Outdated Show resolved Hide resolved
@boxanm
Copy link
Contributor Author

boxanm commented Nov 28, 2023

Good job! There is only one minor comment to address. Also, I was wondering, did you test to make sure it is still possible to refer to the libnabo target in a modern cmake way in dependent projects (e.g., target_link_libraries(my_executable libnabo::nabo))?

The libnabo_LIBRARIES variable is just a placeholder for libnabo::nabo , so nothing prevents you from using that instead. Although I personally think it's cleaner not to hardcode the namespace and library name and to use the variable instead.

@boxanm boxanm changed the base branch from master to develop January 31, 2024 02:15
@boxanm boxanm requested a review from pomerlef as a code owner January 31, 2024 02:15
@boxanm boxanm merged commit e025ce3 into develop Jan 31, 2024
1 check passed
@boxanm boxanm deleted the cmake_package_config_helpers branch January 31, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants