Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of the Visual C++ warnings #355

Merged
merged 6 commits into from Nov 25, 2020

Conversation

afabri
Copy link
Contributor

@afabri afabri commented Sep 2, 2019

This PR is work in progress. It adresses Issue #351.

  • Remove unused variables in catch()
  • Deal with Eigen warnings

@ethzasl-jenkins
Copy link

Can one of the admins verify this patch?

@pomerlef
Copy link
Collaborator

pomerlef commented Sep 2, 2019

ok to test

@@ -0,0 +1,2353 @@
// kate: replace-tabs off; indent-width 4; indent-mode normal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seem to be a temporary file of your text editor. Please remove it.

@@ -0,0 +1 @@
afabri@MALEVICH.7828:1566821008
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@pomerlef
Copy link
Collaborator

@afabri are you still working on this?

@afabri
Copy link
Contributor Author

afabri commented Nov 25, 2020

no.

@pomerlef
Copy link
Collaborator

Alright, I'll merge that in this state and see later for Eigen's warnings

@pomerlef pomerlef merged commit d498b1a into norlab-ulaval:master Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants