Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outlier filter documentation added #392

Merged
merged 6 commits into from
Aug 2, 2020

Conversation

nimisbert
Copy link
Contributor

Hello,

I added a catalog for the outlier filters. It is a corrected version of the google doc.

@ethzasl-jenkins
Copy link

Can one of the admins verify this patch?

@pomerlef
Copy link
Collaborator

ok to test

1 similar comment
@pomerlef
Copy link
Collaborator

ok to test

@pomerlef
Copy link
Collaborator

@AlexandreG87 can you check is the documentation will cause troubles in the readthedoc?
@PhiBabin any comments if you have time?

@aguenette
Copy link
Member

aguenette commented Jul 20, 2020

@nimisbert Can you add your new section to the mkdocs.yml file please?

@pomerlef After that it should be ok. :)

Copy link
Collaborator

@pomerlef pomerlef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! There are some minor points to fix, but it's almost there.

doc/index.md Outdated Show resolved Hide resolved
doc/OutlierFiltersFamilies.md Outdated Show resolved Hide resolved
doc/OutlierFiltersFamilies.md Outdated Show resolved Hide resolved
doc/OutlierFiltersFamilies.md Outdated Show resolved Hide resolved
doc/OutlierFiltersFamilies.md Show resolved Hide resolved
doc/OutlierFiltersFamilies.md Outdated Show resolved Hide resolved
doc/OutlierFiltersFamilies.md Show resolved Hide resolved
doc/OutlierFiltersFamilies.md Outdated Show resolved Hide resolved
doc/OutlierFiltersFamilies.md Show resolved Hide resolved
doc/OutlierFiltersFamilies.md Outdated Show resolved Hide resolved
Copy link
Contributor

@PhiBabin PhiBabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

doc/OutlierFiltersFamilies.md Outdated Show resolved Hide resolved
doc/OutlierFiltersFamilies.md Outdated Show resolved Hide resolved
doc/OutlierFiltersFamilies.md Outdated Show resolved Hide resolved
doc/OutlierFiltersFamilies.md Outdated Show resolved Hide resolved
doc/OutlierFiltersFamilies.md Outdated Show resolved Hide resolved
doc/OutlierFiltersFamilies.md Outdated Show resolved Hide resolved
doc/OutlierFiltersFamilies.md Outdated Show resolved Hide resolved
doc/OutlierFiltersFamilies.md Outdated Show resolved Hide resolved
doc/OutlierFiltersFamilies.md Show resolved Hide resolved
doc/OutlierFiltersFamilies.md Outdated Show resolved Hide resolved
@pomerlef pomerlef merged commit 57a4baa into norlab-ulaval:master Aug 2, 2020
@pomerlef
Copy link
Collaborator

pomerlef commented Aug 2, 2020

Alright, this was a massive PR for a first time ;) Thanks @nimisbert for the great effort and perseverance to carry it to the end.

@AlexandreG87 could you update the readthedoc build to align it with master?

@aguenette
Copy link
Member

@pomerlef I've updated the mkdocs.yml config file to include the new outlier filters documentation, see PR #394.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants