Add dockerhub release logic and improve main readme #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ry` [NMO-442] - move contributing instructions to a contributing_instructions.md file - move commit_msg_reference.md to `doc/contributing directory` - change remaining ethz-asl domain reference to norlab-ulaval - main `README.MD` - move the summary up, under the top banner - add missing installer script instructions - add docker image usage instructions
RedLeader962
requested review from
boxanm,
simonpierredeschenes,
aguenette and
pomerlef
as code owners
…boost.io - see [boost issue #6775](triton-inference-server/server#6775)
boxanm
requested changes
Jan 9, 2024
- Also muted the generate doc flag until UseDoxygen.cmake line 112 is fixed
@boxanm Yes I'm planning to do that this summer. The libpointmatcher dockerhub will have full instruction and will be setup to promote and raise the profile of the codebase. I'll reach out to you when I'll work on that to get your input on a good example/use case design. |
@pomerlef I would like your approval for the changes that I made to the main README.md. Note: The rest of the PR are changes related to release on dockerhub and some build related fix |
simonpierredeschenes
previously approved these changes
Jan 9, 2024
…e badges and add teamcity url to badge
|
boxanm
reviewed
Jan 10, 2024
boxanm
requested changes
Jan 10, 2024
boxanm
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary:
Add the necessary logic to build and push libpointmatcher release docker image to dockerhub.
Also made some improvment to the main readme:
Also fixed the new build failure related to pyton binding compilation via github action
Changes and type of changes (quick overview):
doc/contributing directory[NMO-442]doc/contributing directoryREADME.MDChecklist:
Code related
(i.e.: function, class, script header, README.md)
(Check contributing_instructions.md for local testing procedure using libpointmatcher-build-system)
PR creation related
base refbranch is set to thedevelopbranch(the build-system won't be triggered otherwise)
developbranch(the build-system will reject it otherwise)
PR description related
# <issue-id>if changes are of typefix(See commit_msg_reference.md for details)