Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.4.1 #561

Merged

Conversation

clalancette
Copy link
Contributor

Description

Do a release of 1.4.1 for libpointmatcher

Summary:

The source release of 1.4.0 was done on this repository without bumping the package.xml version. This means that that version cannot be released on the ROS 2 buildfarm to fix https://build.ros2.org/view/Rbin_uN64/job/Rsrc_uN__libpointmatcher__ubuntu_noble__source/

Instead of moving the tag or any other git shenanigans, just make a new release 1.4.1 that properly updates the CHANGELOG and bumps the package.xml. Once this is merged in, I'll need one of the maintainers to also create a tag (1.4.1), at which point we can bloom-release this and fix the build on the ROS 2 buildfarm.

Changes and type of changes (quick overview):

  • 1.4.1 release

Checklist:

Code related

  • [N/A] I have made corresponding changes to the documentation
    (i.e.: function, class, script header, README.md)
  • [N/A] I have commented hard-to-understand code
  • [N/A] I have added tests that prove my fix is effective or that my feature works
  • [N/A] All tests pass locally with my changes
    (Check README.md #Contributing
    for local testing procedure using libpointmatcher-build-system)

PR creation related

  • My pull request base ref branch is set to the develop branch
    (the build-system won't be triggered otherwise)
  • My pull request branch is up-to-date with the develop branch
    (the build-system will reject it otherwise)

PR description related

  • I have included a quick summary of the changes
  • I have indicated the related issue's id with # <issue-id> if changes are of type fix
  • I have included a high-level list of changes and their corresponding type
    • Types: feat fix docs style refactor perf test build ci chore revert
    • Breaking changes: <type>!
    • Reference:
      see commit_msg_reference.md
      in the repository root for details

Note for repository admins

Release PR related

  • Only repository admins have the privilege to push/merge on the default branch (ie: master)
    and the release branch.
  • Keep PR in draft mode until all the release reviewers are ready to push the release.
  • Once a PR from release -> master branch is created (not in draft mode),
    • it triggers the build-system test
    • (in-progress) and it triggers the semantic release automation

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@RedLeader962
Copy link
Collaborator

RedLeader962 commented Mar 19, 2024

@clalancette @boxanm See comment in libnabo PR 135

@RedLeader962
Copy link
Collaborator

@boxanm I'll take care of it, just adding you as a reviewer to keep you in the loop.

@RedLeader962 RedLeader962 merged commit 79c75fe into norlab-ulaval:master Mar 22, 2024
1 check passed
@clalancette clalancette deleted the clalancette/release-1.4.1 branch March 22, 2024 11:54
@clalancette
Copy link
Contributor Author

Thanks for merging and tagging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants