Added mkdtemp and sorted exports list. #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes out #40 |
haoxins
reviewed
Oct 11, 2016
| 'symlink', | ||
| 'lstat', | ||
| 'mkdir', | ||
| 'mkdtemp', |
There was a problem hiding this comment.
Personally, I'd like to split add mkdtemp and sort the list to different PRs ((_))
There was a problem hiding this comment.
I agree too, but I think this is good enough for now...
|
@EvanCarroll Could you please add a test as well? 💌 |
|
This module not having a testing a suite is an issue in and of itself. I don't have the time nor concern to tackle that issue. Not a single function, afaik, is testing in mz/fs.js |
|
Tests exists: https://github.com/normalize/mz/blob/master/test/mz.js#L4-L48 I think that this should just be adding ~6 lines of code, but maybe I'm wrong? |
|
Looks like this was fixed in 4dd2cfe. |
|
Cool 👌 Feel free to send a new pull request which sorts all the lists :) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.