Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added mkdtemp and sorted exports list. #41

Closed
wants to merge 2 commits into from
Closed

Added mkdtemp and sorted exports list. #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac7f981
added mkdtemp and sorted the list
EvanCarroll Oct 10, 2016
07e9200
sorted the exports list for the rest of the files
EvanCarroll Oct 10, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion crypto.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ require('thenify-all').withCallback(
require('crypto'),
exports, [
'pbkdf2',
'randomBytes',
'pseudoRandomBytes',
'randomBytes',
]
)
6 changes: 3 additions & 3 deletions dns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ require('thenify-all').withCallback(
'resolve',
'resolve4',
'resolve6',
'resolveCname',
'resolveMx',
'resolveTxt',
'resolveSrv',
'resolveNs',
'resolveCname',
'resolveSrv',
'resolveTxt',
'reverse',
]
)
39 changes: 20 additions & 19 deletions fs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,35 +8,36 @@ try {
}

var api = [
'rename',
'ftruncate',
'chown',
'fchown',
'lchown',
'appendFile',
'chmod',
'chown',
'close',
'fchmod',
'stat',
'lstat',
'fchown',
'fstat',
'fsync',
'ftruncate',
'futimes',
'lchown',
'link',
'symlink',
'lstat',
'mkdir',
'mkdtemp',
Copy link
Member

@haoxins haoxins Oct 11, 2016 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I'd like to split add mkdtemp and sort the list to different PRs ((_))

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, in retrospect..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree too, but I think this is good enough for now...

'open',
'read',
'readFile',
'readdir',
'readlink',
'realpath',
'unlink',
'rename',
'rmdir',
'mkdir',
'readdir',
'close',
'open',
'stat',
'symlink',
'truncate',
'unlink',
'utimes',
'futimes',
'fsync',
'write',
'read',
'readFile',
'writeFile',
'appendFile',
'truncate',
]

typeof fs.access === 'function' && api.push('access')
Expand Down
2 changes: 1 addition & 1 deletion zlib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ require('thenify-all').withCallback(
exports, [
'deflate',
'deflateRaw',
'gzip',
'gunzip',
'gzip',
'inflate',
'inflateRaw',
'unzip',
Expand Down