ActiveRecord::RecordNotFound when validations fail

[fschwahn]

Hi,
I'm using the following versions:

rails (3.1.0)
friendly_id (4.0.0.beta10)
ruby 1.8.7 (2011-02-18 patchlevel 334) [i686-darwin10.8.0], MBARI 0x6770, Ruby Enterprise Edition 2011.03

I have a model like this:

class Picture < ActiveRecord::Base
  extend FriendlyId

  friendly_id :name, :use => :slugged

  # ...

  private
    def normalize_friendly_id(text)
      text.to_slug.normalize! :transliterate => :german
    end

end

When I edit this model and change the name (which is used for the slug), and a validation fails, I am correctly redirected back to the form. However, when I send the form again, a ActiveRecord::RecordNotFound-exception is raised.

Thanks for the great gem!

[norman]

The error is happening across two requests, and I'm not sure what your form does, or what parameters it sends. If you can show me more explicitly the steps to reproduce the problem, I'd be happy to look into it but from the information you've given so far I suspect it may be best to debug your application a bit more to figure out if FriendlyId is really the problem, and if so, how and why.

[fschwahn]

I reproduced the bug in a minimal app, I can upload it if you like.
I think the problem is that I change the field (e.g. title) from which the slug is created, but a validation fails, and thus the updated title and slug aren't saved to the database. But when the form is re-submitted friendly_id will do the lookup using the new slug which hasn't been persisted yet. The error message I get if I change the title to lala is:

Couldn't find Post with id=lala

In my minimal app the form is a vanilla rails scaffolded form.

[norman]

Sure if you could upload the app somewhere or email it to norman@njclarke.com that would be great. Thanks!

[fschwahn]

You can find the app here: https://github.com/fschwahn/friendly_id_issue_148
The instructions to get it running are inside the README.

[norman]

Thanks a lot for the help reproducing the bug. I've added a failing test for the issue and will get a fix in as soon as possible.

[fschwahn]

Thanks for fixing it! I just tested it was my app and it works now.