Using attr_accessible for Slug attributes #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pulled. Thanks! |
Empact
pushed a commit
to Empact/friendly_id
that referenced
this pull request
Jan 21, 2012
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ActiveRecord
Slugmodel doesn't specify accessible attributes, preventing the record from being saved when model attributes have been set to protected by default, eg, usingActiveRecord::Base.send(:attr_accessible, nil)in a Rails initializer. This commit uses theattr_accessiblemacro to specify whitelisted attributes onSlug. All existing tests pass.