fix History + SequentiallySlugged + Scope issues #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parndt
reviewed
Jul 22, 2018
| base_class = Slug | ||
| else | ||
| base_class = self.class.base_class | ||
| end |
There was a problem hiding this comment.
could you extract this into a method base_class?
parndt
reviewed
Jul 22, 2018
| @@ -7,11 +7,17 @@ def self.setup(model_class) | |||
| def resolve_friendly_id_conflict(candidate_slugs) | |||
| candidate = candidate_slugs.first | |||
| return if candidate.nil? | |||
| SequentialSlugCalculator.new(scope_for_slug_generator, | |||
| scope = scope_for_slug_generator | |||
There was a problem hiding this comment.
this could probably go back to being used inline?
SequentialSlugCalculator.new(scope_for_slug_generator,because it doesn't get re-used so it doesn't appear to need to be a variable
|
This have been running for 3 weeks in production, the only problem I've found is that I have |
|
Thanks a lot @kshnurov 👍 |
This was referenced Nov 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SequentiallySluggedwithHistorydoesn't look into previously used slugs, which can result in a wronglast_sequence_numberand failure.