Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.0.0 #288

Merged
merged 134 commits into from
Dec 17, 2018
Merged

Release 2.0.0 #288

merged 134 commits into from
Dec 17, 2018

Conversation

dbarrosop
Copy link
Contributor

No description provided.

dbarrosop and others added 30 commits July 12, 2018 21:18
* safe_load is deprecated and was replaced with ruamel.yaml.YAML
Add initial expansion of DSL acronym.
* add readthedocs yaml file

* minor rearrangement

* add missing data class
* Attempt at creating a custom inventory using NetBox as a backend (#162)

Added inventory plugin for NetBox

* fix tests for netbox

* address comments

* fix comment

* use raise_on_status instead of try...except.. block

* make black happy
* Refactor connection plugins

* migrate tasks to new connection plugin mechanism

* update mypy conf

* update docs and tests

* replace Connections.__del__ with a context manager for Nornir

* Roll setup.py to indicate version 2.x.x (#199)

* Roll setup.py to indicate version 2.x.x

* Fix issue with None timeout value

* addressing various minor comments

* handle better opening/closing connections

* add tests

* fix and test context manager

* connection-related exceptions should inherit from ConnectionException
ktbyers and others added 24 commits November 9, 2018 10:13
Add enable argument to Netmiko send_command
Fixed an issue deserializing ansible inventory
fix typo on line 291
Docfix minor error for contributing
Plugin for netmiko save_config() method
Needed to add the key to access the nested value.
Update grouping_tasks.ipynb
@dbarrosop dbarrosop merged commit f725a35 into master Dec 17, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1087

  • 899 of 954 (94.23%) changed or added relevant lines in 41 files are covered.
  • 26 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.3%) to 92.207%

Changes Missing Coverage Covered Lines Changed/Added Lines %
nornir/core/deserializer/configuration.py 95 96 98.96%
nornir/plugins/connections/netmiko.py 15 16 93.75%
nornir/plugins/inventory/nsot.py 17 18 94.44%
nornir/plugins/tasks/data/echo_data.py 2 3 66.67%
nornir/plugins/tasks/files/sftp.py 13 14 92.86%
nornir/plugins/tasks/networking/netmiko_send_command.py 5 6 83.33%
nornir/core/state.py 9 11 81.82%
nornir/core/connections.py 38 41 92.68%
nornir/core/configuration.py 55 59 93.22%
nornir/plugins/inventory/ansible.py 112 116 96.55%
Files with Coverage Reduction New Missed Lines %
nornir/plugins/inventory/ansible.py 1 96.89%
nornir/core/exceptions.py 1 70.73%
nornir/plugins/tasks/networking/tcp_ping.py 2 92.0%
nornir/core/helpers/init.py 6 14.29%
nornir/core/inventory.py 16 87.78%
Totals Coverage Status
Change from base Build 770: 0.3%
Covered Lines: 1408
Relevant Lines: 1527

💛 - Coveralls

4 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1087

  • 899 of 954 (94.23%) changed or added relevant lines in 41 files are covered.
  • 26 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.3%) to 92.207%

Changes Missing Coverage Covered Lines Changed/Added Lines %
nornir/core/deserializer/configuration.py 95 96 98.96%
nornir/plugins/connections/netmiko.py 15 16 93.75%
nornir/plugins/inventory/nsot.py 17 18 94.44%
nornir/plugins/tasks/data/echo_data.py 2 3 66.67%
nornir/plugins/tasks/files/sftp.py 13 14 92.86%
nornir/plugins/tasks/networking/netmiko_send_command.py 5 6 83.33%
nornir/core/state.py 9 11 81.82%
nornir/core/connections.py 38 41 92.68%
nornir/core/configuration.py 55 59 93.22%
nornir/plugins/inventory/ansible.py 112 116 96.55%
Files with Coverage Reduction New Missed Lines %
nornir/plugins/inventory/ansible.py 1 96.89%
nornir/core/exceptions.py 1 70.73%
nornir/plugins/tasks/networking/tcp_ping.py 2 92.0%
nornir/core/helpers/init.py 6 14.29%
nornir/core/inventory.py 16 87.78%
Totals Coverage Status
Change from base Build 770: 0.3%
Covered Lines: 1408
Relevant Lines: 1527

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1087

  • 899 of 954 (94.23%) changed or added relevant lines in 41 files are covered.
  • 26 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.3%) to 92.207%

Changes Missing Coverage Covered Lines Changed/Added Lines %
nornir/core/deserializer/configuration.py 95 96 98.96%
nornir/plugins/connections/netmiko.py 15 16 93.75%
nornir/plugins/inventory/nsot.py 17 18 94.44%
nornir/plugins/tasks/data/echo_data.py 2 3 66.67%
nornir/plugins/tasks/files/sftp.py 13 14 92.86%
nornir/plugins/tasks/networking/netmiko_send_command.py 5 6 83.33%
nornir/core/state.py 9 11 81.82%
nornir/core/connections.py 38 41 92.68%
nornir/core/configuration.py 55 59 93.22%
nornir/plugins/inventory/ansible.py 112 116 96.55%
Files with Coverage Reduction New Missed Lines %
nornir/plugins/inventory/ansible.py 1 96.89%
nornir/core/exceptions.py 1 70.73%
nornir/plugins/tasks/networking/tcp_ping.py 2 92.0%
nornir/core/helpers/init.py 6 14.29%
nornir/core/inventory.py 16 87.78%
Totals Coverage Status
Change from base Build 770: 0.3%
Covered Lines: 1408
Relevant Lines: 1527

💛 - Coveralls

@coveralls
Copy link

coveralls commented Dec 17, 2018

Pull Request Test Coverage Report for Build 1087

  • 899 of 954 (94.23%) changed or added relevant lines in 41 files are covered.
  • 26 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.3%) to 92.207%

Changes Missing Coverage Covered Lines Changed/Added Lines %
nornir/core/deserializer/configuration.py 95 96 98.96%
nornir/plugins/connections/netmiko.py 15 16 93.75%
nornir/plugins/inventory/nsot.py 17 18 94.44%
nornir/plugins/tasks/data/echo_data.py 2 3 66.67%
nornir/plugins/tasks/files/sftp.py 13 14 92.86%
nornir/plugins/tasks/networking/netmiko_send_command.py 5 6 83.33%
nornir/core/state.py 9 11 81.82%
nornir/core/connections.py 38 41 92.68%
nornir/core/configuration.py 55 59 93.22%
nornir/plugins/inventory/ansible.py 112 116 96.55%
Files with Coverage Reduction New Missed Lines %
nornir/plugins/inventory/ansible.py 1 96.89%
nornir/core/exceptions.py 1 70.73%
nornir/plugins/tasks/networking/tcp_ping.py 2 92.0%
nornir/core/helpers/init.py 6 14.29%
nornir/core/inventory.py 16 87.78%
Totals Coverage Status
Change from base Build 770: 0.3%
Covered Lines: 1408
Relevant Lines: 1527

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1087

  • 899 of 954 (94.23%) changed or added relevant lines in 41 files are covered.
  • 26 unchanged lines in 5 files lost coverage.
  • Overall coverage increased (+0.3%) to 92.207%

Changes Missing Coverage Covered Lines Changed/Added Lines %
nornir/core/deserializer/configuration.py 95 96 98.96%
nornir/plugins/connections/netmiko.py 15 16 93.75%
nornir/plugins/inventory/nsot.py 17 18 94.44%
nornir/plugins/tasks/data/echo_data.py 2 3 66.67%
nornir/plugins/tasks/files/sftp.py 13 14 92.86%
nornir/plugins/tasks/networking/netmiko_send_command.py 5 6 83.33%
nornir/core/state.py 9 11 81.82%
nornir/core/connections.py 38 41 92.68%
nornir/core/configuration.py 55 59 93.22%
nornir/plugins/inventory/ansible.py 112 116 96.55%
Files with Coverage Reduction New Missed Lines %
nornir/plugins/inventory/ansible.py 1 96.89%
nornir/core/exceptions.py 1 70.73%
nornir/plugins/tasks/networking/tcp_ping.py 2 92.0%
nornir/core/helpers/init.py 6 14.29%
nornir/core/inventory.py 16 87.78%
Totals Coverage Status
Change from base Build 770: 0.3%
Covered Lines: 1408
Relevant Lines: 1527

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet