Remove the external ping test #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1099
💛 - Coveralls |
By having a test for external connectivity which isn't stubbed, what's actually being tested is the network environment of the development machine, and not the nornir code. There are several examples where this test would legitimately fail: - Offline laptop - Corporate environment with restrictive firewall policies. As such, a failing test does not necessarily indicate an issue with the code. A failed test will cause downstream tools that depend on passing tests to fail, or leave developers wasting time looking for non-existent faults.
optiz0r
force-pushed
the
remove_external_ping_test
branch
from
b1268df
to
47af98d
Compare
|
I agree, might be nice to mock though. I am going to merge it to avoid unblocking this issue but I think we should basically create a docker-compose file to orchestrate a few containers. I will create an issue for that. |
dbarrosop
reviewed
Dec 28, 2018
|
|
||
| def test_tcp_ping_external_hosts(self): | ||
| external = InitNornir( | ||
| inventory={"options": {"host_file": ext_inv_file}}, dry_run=True |
There was a problem hiding this comment.
Is the file needed at all? We can probably remove the resources that were used by this test.
optiz0r
force-pushed
the
remove_external_ping_test
branch
from
939e9d6
to
708e292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By having a test for external connectivity which isn't stubbed,
what's actually being tested is the network environment of the development
machine, and not the nornir code. There are several examples where
this test would legitimately fail:
As such, a failing test does not necessarily indicate an issue with the
code. A failed test will cause downstream tools that depend on passing
tests to fail, or leave developers wasting time looking for non-existent
faults.