-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isolate test environment with docker-compose #296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1101
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 1101
💛 - Coveralls |
Pull Request Test Coverage Report for Build 1108
💛 - Coveralls |
d4c3498
to
277c9ec
Compare
277c9ec
to
7b36169
Compare
Looks reasonable. Have only looked on my phone. Only comment is in wrapper.py.
If I remember correctly the assert in this code will only show true/false. So if the output doesn’t match the reference the user will only see that something is wrong but not what. I.e., that’s a Python assert not a Pytest assert.
if screen_output != reference_output:
raise Exception(screen_output, reference_output)
assert screen_output == reference_output
… On 29 Dec 2018, at 10:57, David Barroso ***@***.***> wrote:
@ogenstad @dmfigol @ktbyers
This changes slightly the development workflow (I updated the contributing guidelines) but I think it's worth the change as it will lead to less obscure crap going on in travis.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
assert throws an Assertion error, for instance, the REPL:
|
That was my point a user will only see that an error occurred, but not why.
… On 29 Dec 2018, at 12:04, David Barroso ***@***.***> wrote:
the assert in this code will only show true/false
assert throws an Assertion error, for instance, the REPL:
>>> assert 1 == 2
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
AssertionError
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I tested this in my AWS AMI environment (fedora-based). It was fine. I had to install docker-compose using curl, but everything was pretty straight-forward after that. +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #295
This tries to accomplish a few things: