isolate test environment with docker-compose

[dbarrosop]

Solves #295

This tries to accomplish a few things:

1. Isolate completely the testing environment so everybody has the same regardless of if it's local or in travis (pandoc issues anyone? ;) )
2. Allow orchestrating containers more easily. Right now there is a bash script that starts containers that needs to be instantiated with pytest. With this you can start them and have them running in the background which may allow you to iterate faster.
3. Avoids issues like Remove the external ping test #293 as we can add local resources and link them. So no more tests pointing to localhost :)
4. Gets rid of tox which I never liked.

[coveralls]

Pull Request Test Coverage Report for Build 1101

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at ?%

---

Totals
Change from base Build 1097:	0.0%
Covered Lines:
Relevant Lines:	0

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 1101

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at ?%

---

Totals
Change from base Build 1097:	0.0%
Covered Lines:
Relevant Lines:	0

---

💛 - Coveralls

[coveralls]

Pull Request Test Coverage Report for Build 1108

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at ?%

---

Totals
Change from base Build 1102:	0.0%
Covered Lines:
Relevant Lines:	0

---

💛 - Coveralls

[dbarrosop]

@ogenstad @dmfigol @ktbyers

This changes slightly the development workflow (I updated the contributing guidelines) but I think it's worth the change as it will lead to less obscure crap going on in travis.

[ogenstad]

Looks reasonable. Have only looked on my phone. Only comment is in wrapper.py. If I remember correctly the assert in this code will only show true/false. So if the output doesn’t match the reference the user will only see that something is wrong but not what. I.e., that’s a Python assert not a Pytest assert. if screen_output != reference_output: raise Exception(screen_output, reference_output) assert screen_output == reference_output

…

On 29 Dec 2018, at 10:57, David Barroso ***@***.***> wrote: @ogenstad @dmfigol @ktbyers This changes slightly the development workflow (I updated the contributing guidelines) but I think it's worth the change as it will lead to less obscure crap going on in travis. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[dbarrosop]

the assert in this code will only show true/false

assert throws an Assertion error, for instance, the REPL:

>>> assert 1 == 2
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
AssertionError

[ogenstad]

That was my point a user will only see that an error occurred, but not why.

…

On 29 Dec 2018, at 12:04, David Barroso ***@***.***> wrote: the assert in this code will only show true/false assert throws an Assertion error, for instance, the REPL: >>> assert 1 == 2 Traceback (most recent call last): File "<stdin>", line 1, in <module> AssertionError — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[ktbyers]

I tested this in my AWS AMI environment (fedora-based). It was fine. I had to install docker-compose using curl, but everything was pretty straight-forward after that.

+1