Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trouble with Unicode identifiers #3

Closed
anyahelene opened this issue Sep 3, 2019 · 1 comment
Closed

trouble with Unicode identifiers #3

anyahelene opened this issue Sep 3, 2019 · 1 comment

Comments

@anyahelene
Copy link
Contributor 

public class Problem3 {
	public static final String EMOJI_𓅭 = "🦆";

	public void method_𧅄() {

	}
	public void method_𓉐() {
		return;
	}
}
anyahelene added a commit to anyahelene/autumn that referenced this issue Sep 5, 2019
@anyahelene
Use 32-bit characters (int) instead of Java's native char
f2d2b82 
This should avoid issues with code points in the supplementary
multilingual planes (0x010000–0x10FFFF) being split across two chars.

CharPredicate now takes ints instead of chars, and other uses of char
have mostly been replaced by int, with some exceptions in the Java
LexUtils.

Seems to be working, at least for the Java grammar, and fixes issue norswap#3.
norswap pushed a commit that referenced this issue Nov 22, 2020
@anyahelene @norswap
Use 32-bit characters (int) instead of Java's native char
5bdf742 
This should avoid issues with code points in the supplementary
multilingual planes (0x010000–0x10FFFF) being split across two chars.

CharPredicate now takes ints instead of chars, and other uses of char
have mostly been replaced by int, with some exceptions in the Java
LexUtils.

Seems to be working, at least for the Java grammar, and fixes issue #3.
@norswap
Copy link
Owner

norswap commented Nov 22, 2020

PR merged & test cases added in 3436711

@norswap norswap closed this as completed Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@norswap @anyahelene