Merge c6bba36 into 2596299

pkg/apis/kanali.io/v2/register.go

@@ -50,7 +50,7 @@ func init() {
 	localSchemeBuilder.Register(addKnownTypes)
 }
 
-// Adds the list of known types to api.Scheme.
+// addKnownTypes adds the list of known types to api.Scheme.
 func addKnownTypes(scheme *runtime.Scheme) error {
 	scheme.AddKnownTypes(SchemeGroupVersion,
 		&ApiKey{},

pkg/client/informers/externalversions/factory.go

@@ -103,7 +103,7 @@ func (f *sharedInformerFactory) WaitForCacheSync(stopCh <-chan struct{}) map[ref
 	return res
 }
 
-// InternalInformerFor returns the SharedIndexInformer for obj using an internal
+// InformerFor returns the SharedIndexInformer for obj using an internal
 // client.
 func (f *sharedInformerFactory) InformerFor(obj runtime.Object, newFunc internalinterfaces.NewInformerFunc) cache.SharedIndexInformer {
 	f.lock.Lock()

pkg/flow/plugins.go

@@ -49,7 +49,7 @@ var (
 	}
 )
 
-// join will return the path to the compiled plugin.
+// combinePath; join will return the path to the compiled plugin.
 // While this path is not guaranteed to be absolute,
 // the plugin package will make it absolute:
 // https://github.com/golang/go/blob/master/src/plugin/plugin_dlopen.go#L56-L60

pkg/flow/pluginsonresponse.go

@@ -41,7 +41,7 @@ func PluginsOnResponseStep() Step {
 	return pluginsOnResponseStep{}
 }
 
-// GetName retruns the name of the PluginsOnResponseStep step
+// Name retruns the name of the PluginsOnResponseStep step
 func (step pluginsOnResponseStep) Name() string {
 	return "Plugin OnResponse"
 }

pkg/flow/validateproxy.go

@@ -43,7 +43,7 @@ func ValidateProxyStep() Step {
 	return validateProxyStep{}
 }
 
-// GetName retruns the name of the ValidateProxyStep step
+// Name retruns the name of the ValidateProxyStep step
 func (step validateProxyStep) Name() string {
 	return "Validate Proxy"
 }

pkg/log/log_test.go

@@ -64,7 +64,7 @@ func TestWithContext(t *testing.T) {
 	assert.Equal(t, logger, WithContext(ctx))
 }
 
-// There is no way actually test this yet.
+// TestAddMetrics; There is no way actually test this yet.
 // But I still want the code coverage :)
 // https://github.com/prometheus/client_golang/issues/58
 func TestAddMetrics(t *testing.T) {

plugins/apikey/plugin.go

@@ -139,7 +139,7 @@ func validateApiKey(rule *v2.Rule, method string) bool {
 	return rule.Global || validateGranularRules(method, rule.Granular)
 }
 
-// check to see wheather a given HTTP method can be found
+// validateGranularRules checks to see wheather a given HTTP method can be found
 // in the list of HTTP methods belonging to a spec.GranularProxy
 func validateGranularRules(method string, rule v2.GranularProxy) bool {
 	if len(rule.Verbs) < 1 {